From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: sj1557.seo@samsung.com, yuezhang.mo@sony.com,
linux-fsdevel@vger.kernel.org, anmuxixixi@gmail.com,
dxdt@dev.snart.me, chizhiling@kylinos.cn, chizhiling@163.com
Subject: Re: [PATCH 2/5] exfat: add iomap direct I/O support
Date: Mon, 30 Mar 2026 08:33:21 +0200 [thread overview]
Message-ID: <20260330063321.GB5897@lst.de> (raw)
In-Reply-To: <20260326115045.9525-3-linkinjeon@kernel.org>
On Thu, Mar 26, 2026 at 08:50:42PM +0900, Namjae Jeon wrote:
> + if (iocb->ki_flags & IOCB_DIRECT) {
> + ret = iomap_dio_rw(iocb, iter, &exfat_write_iomap_ops,
> + &exfat_write_dio_ops, 0, NULL, 0);
> + if (ret == -ENOTBLK)
> + ret = 0;
This seems to miss a fallback to __generic_file_write_iter?
> + inode_lock_shared(inode);
> + if (iocb->ki_flags & IOCB_DIRECT) {
> + size_t count = iov_iter_count(iter);
> +
> + if ((iocb->ki_pos | count) & (inode->i_sb->s_blocksize - 1)) {
> + ret = -EINVAL;
> + goto inode_unlock;
> + }
iomap_dio_bio_iter() should already take care of the alignment check.
> - .direct_IO = exfat_direct_IO,
> + .direct_IO = noop_direct_IO,
This should not be needed, setting FMODE_CAN_ODIRECT in ->open should
be all that is needed.
next prev parent reply other threads:[~2026-03-30 6:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 11:50 [PATCH 0/5] exfat: convert to iomap Namjae Jeon
2026-03-26 11:50 ` [PATCH 1/5] exfat: add iomap support Namjae Jeon
2026-03-30 2:45 ` Chi Zhiling
2026-03-31 5:29 ` Namjae Jeon
2026-03-30 6:30 ` Christoph Hellwig
2026-03-31 5:26 ` Namjae Jeon
2026-03-31 5:48 ` Christoph Hellwig
2026-03-31 6:44 ` Namjae Jeon
2026-04-01 3:07 ` Chi Zhiling
2026-04-01 2:24 ` Yuezhang.Mo
2026-04-01 2:47 ` Namjae Jeon
2026-04-06 13:45 ` David Timber
2026-04-06 14:13 ` David Timber
2026-03-26 11:50 ` [PATCH 2/5] exfat: add iomap direct I/O support Namjae Jeon
2026-03-30 6:33 ` Christoph Hellwig [this message]
2026-03-31 5:23 ` Namjae Jeon
2026-03-26 11:50 ` [PATCH 3/5] exfat: add iomap buffered " Namjae Jeon
2026-03-30 6:38 ` Christoph Hellwig
2026-03-31 5:22 ` Namjae Jeon
2026-03-31 5:46 ` Christoph Hellwig
2026-03-31 6:36 ` Namjae Jeon
2026-03-31 6:37 ` Christoph Hellwig
2026-03-31 6:58 ` Namjae Jeon
2026-04-06 13:09 ` David Timber
2026-04-07 6:28 ` Christoph Hellwig
2026-04-07 9:18 ` Namjae Jeon
2026-03-26 11:50 ` [PATCH 4/5] exfat: add support for multi-cluster allocation Namjae Jeon
2026-03-26 11:50 ` [PATCH 5/5] exfat: add support for SEEK_HOLE and SEEK_DATA in llseek Namjae Jeon
2026-03-30 6:39 ` Christoph Hellwig
2026-03-31 4:55 ` Namjae Jeon
2026-03-27 6:33 ` [PATCH 0/5] exfat: convert to iomap Christoph Hellwig
2026-03-27 6:46 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330063321.GB5897@lst.de \
--to=hch@lst.de \
--cc=anmuxixixi@gmail.com \
--cc=chizhiling@163.com \
--cc=chizhiling@kylinos.cn \
--cc=dxdt@dev.snart.me \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox