From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
sj1557.seo@samsung.com, yuezhang.mo@sony.com,
linux-fsdevel@vger.kernel.org, anmuxixixi@gmail.com,
dxdt@dev.snart.me, chizhiling@kylinos.cn, chizhiling@163.com
Subject: Re: [PATCH 3/5] exfat: add iomap buffered I/O support
Date: Tue, 31 Mar 2026 07:46:16 +0200 [thread overview]
Message-ID: <20260331054616.GA31506@lst.de> (raw)
In-Reply-To: <CAKYAXd9pZx1g=53wtCh0xTVYgQCLNz1sEL-2-fHbkSHQ=qTiTg@mail.gmail.com>
On Tue, Mar 31, 2026 at 02:22:57PM +0900, Namjae Jeon wrote:
> There is a deadlock issue when using iomap_dio_rw(). In
> exfat_write_iter(), the inode lock is held while calling iomap_dio_rw.
> generic_write_sync()->__generic_file_fsync() in iomap_dio_complete()
> can be triggered, which attempts to acquire the inode lock again.
Can you document this? Note that Jan has looked into __generic_file_fsync
and decided i_rwsem isn't needed there. So maybe as a first step just
switch exfat to generic_buffers_fsync_noflush, which doesn't need this
(or way if/when Jan's series gets merged) and keep using a generic
version? If not document in the commit log why this is changed.
next prev parent reply other threads:[~2026-03-31 5:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 11:50 [PATCH 0/5] exfat: convert to iomap Namjae Jeon
2026-03-26 11:50 ` [PATCH 1/5] exfat: add iomap support Namjae Jeon
2026-03-30 2:45 ` Chi Zhiling
2026-03-31 5:29 ` Namjae Jeon
2026-03-30 6:30 ` Christoph Hellwig
2026-03-31 5:26 ` Namjae Jeon
2026-03-31 5:48 ` Christoph Hellwig
2026-03-31 6:44 ` Namjae Jeon
2026-04-01 3:07 ` Chi Zhiling
2026-04-01 2:24 ` Yuezhang.Mo
2026-04-01 2:47 ` Namjae Jeon
2026-04-06 13:45 ` David Timber
2026-04-06 14:13 ` David Timber
2026-03-26 11:50 ` [PATCH 2/5] exfat: add iomap direct I/O support Namjae Jeon
2026-03-30 6:33 ` Christoph Hellwig
2026-03-31 5:23 ` Namjae Jeon
2026-03-26 11:50 ` [PATCH 3/5] exfat: add iomap buffered " Namjae Jeon
2026-03-30 6:38 ` Christoph Hellwig
2026-03-31 5:22 ` Namjae Jeon
2026-03-31 5:46 ` Christoph Hellwig [this message]
2026-03-31 6:36 ` Namjae Jeon
2026-03-31 6:37 ` Christoph Hellwig
2026-03-31 6:58 ` Namjae Jeon
2026-04-06 13:09 ` David Timber
2026-03-26 11:50 ` [PATCH 4/5] exfat: add support for multi-cluster allocation Namjae Jeon
2026-03-26 11:50 ` [PATCH 5/5] exfat: add support for SEEK_HOLE and SEEK_DATA in llseek Namjae Jeon
2026-03-30 6:39 ` Christoph Hellwig
2026-03-31 4:55 ` Namjae Jeon
2026-03-27 6:33 ` [PATCH 0/5] exfat: convert to iomap Christoph Hellwig
2026-03-27 6:46 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331054616.GA31506@lst.de \
--to=hch@lst.de \
--cc=anmuxixixi@gmail.com \
--cc=chizhiling@163.com \
--cc=chizhiling@kylinos.cn \
--cc=dxdt@dev.snart.me \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox