From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6D82EC57C for ; Tue, 31 Mar 2026 07:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774940751; cv=none; b=TV9QEydL/5joyLoovXc/kNlrRjEFhYWGPFZj+/bPD/Sqf7BbeQ/ZwIR8/lZAs0aymj4rLd7ZJ4D8EMj7PEbruBIosOYBv1qASSi+BiAGjMSKgrgARcF+81lVpE0D1M2/z1Cn8WLcTGj/PsVJXg8BUZnyP25PI+YRAK7bgtdNI+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774940751; c=relaxed/simple; bh=mkcJQ3h0tmlWxuk9zS5/dDgGfHrPG4sAKhKsDysAhS0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GnM64QjjMDbnGd2gEQ5SwKDKgsGg9Rj5t12zfCeFCgr1ZhVNQ+uIU2LBkoyuk5rkgfWEj6Iu/cIF9vmBCwUouiz9NZBbIkAde7QXaIHdWy4dPZJTc2+ta0EHRrHnLpzKElqW7LZXraEqIQgDtne8lGP/YY3LwVUvfo3GMMHQ9SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=wGXb3XKN; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=2ROY/o49; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=0CWaQSGr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=ne0Sr2iU; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="wGXb3XKN"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="2ROY/o49"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="0CWaQSGr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="ne0Sr2iU" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5A3C45BEA6; Tue, 31 Mar 2026 07:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774940748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GAV45UTadaXeFSHm/AZxMTClq736FfUhqafLXXxKAN4=; b=wGXb3XKNXxnGZoWOSksh3c57+WHOnx79UgU9nniHvHy3TUsi9ey62UkY8YMiwRliK6FEV+ YLIzuQAlafjV26rxVwEVBOAaDdGj0etGX6rONX+jP9ikgFr3Ca4/xVHu9fjYHSqVuHaUFc RGKn2OuJuJTx+1zkiIVDaKW1nGeXQE4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774940748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GAV45UTadaXeFSHm/AZxMTClq736FfUhqafLXXxKAN4=; b=2ROY/o49DTd0BDFt2/GmB9sACa/QvXCdYRyjVU/m6epIXfcB33/5kday5wid+e6QibDqnL YJddP5KvnItoieAw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774940747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GAV45UTadaXeFSHm/AZxMTClq736FfUhqafLXXxKAN4=; b=0CWaQSGrBhy6jtfeX90fGFuVKznNP0APcqS+TVj2OpsHVX1APNfY3sdle/DAoEuX6yPOAd t6tbC/ktjhiPUe1urT3PTqHswGoAtIi+u/xwtoKDWil8QUj0J1/WBqgwaiTu55yqhj2h2N mUMLqLyAScK91fRjBWSfI0twDD/M8+w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774940747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=GAV45UTadaXeFSHm/AZxMTClq736FfUhqafLXXxKAN4=; b=ne0Sr2iU+JFs2Dm4Pt1puxXCMMseVFN1kNGEBn/tPO+C1LsGm6cGh69rlR2ld4UQifYjiO y7KrnECHbVOBmxCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5C7354A0A2; Tue, 31 Mar 2026 07:05:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XDmxBUdyy2mEQAAAD6G6ig (envelope-from ); Tue, 31 Mar 2026 07:05:43 +0000 From: David Disseldorp To: Andy Shevchenko , David Disseldorp , Petr Mladek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Al Viro , Christian Brauner , Jan Kara , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton Subject: [PATCH v5 0/6] initramfs: test and improve cpio hex header validation Date: Tue, 31 Mar 2026 17:57:30 +1100 Message-ID: <20260331070519.5974-1-ddiss@suse.de> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[12]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email,intel.com:email]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: v5 changes: - rework 2/6 and 4/6 test comment, as suggested by Andy - 2/6: initialize struct kstat in tests to account for possible init_stat() failure + drop Andy's review tag due to this minor change ---------------------------------------------------------------- v4: 20260329105307.2876-1-ddiss@suse.de - rework initramfs_test changes to use an inject_ox parameter instead of having tests pass through an unvalidated format string. + drop Andy's reviewed-by from 1/6 and 2/6 to account for changed test + 4/6 minor changes for test context and comment - add review tags for 3/6, 5/6 and 6/6 following list feedback ---------------------------------------------------------------- v3: 20260323150054.3587083-1-andriy.shevchenko@linux.intel.com The series that introduced simple_strntoul() had passed into kernel without proper review and hence reinvented a wheel that's not needed. Here is the refactoring to show that. It can go via PRINTK or VFS tree. I have tested this on x86, but I believe the same result will be on big-endian CPUs (I deduced that from how strtox() works). I also run KUnit tests. Changelog v3: - rebased on top of latest kernel - squashed patches proposed by David v2: 20260121172749.32322-1-ddiss@suse.de v1: 20260119204151.1447503-1-andriy.shevchenko@linux.intel.com ---------------------------------------------------------------- Andy Shevchenko (4): initramfs: Sort headers alphabetically initramfs: Refactor to use hex2bin() instead of custom approach vsprintf: Revert "add simple_strntoul" kstrtox: Drop extern keyword in the simple_strtox() declarations David Disseldorp (2): initramfs_test: add fill_cpio() inject_ox parameter initramfs_test: test header fields with 0x hex prefix include/linux/kstrtox.h | 9 +++-- init/initramfs.c | 68 +++++++++++++++++++---------------- init/initramfs_test.c | 80 +++++++++++++++++++++++++++++++++-------- lib/vsprintf.c | 7 ---- 4 files changed, 107 insertions(+), 57 deletions(-)