Re: [PATCH 2/2] smb: client: add support for O_TMPFILE

[Al Viro <viro@zeniv.linux.org.uk>]

On Mon, Apr 06, 2026 at 10:28:51PM -0300, Paulo Alcantara wrote:

> IIUC, this is what we currently have
> 
> * cifs_atomic_open()
> 
>   init state: in-lookup or hashed-negative
>   [d_drop() + d_add()]
>   end state: hashed-positive
> 
> * cifs_tmpfile()
> 
>   init state: unhashed-negative
>   [d_drop() + d_instantiate()]
>   end state: unhashed-positive
> 
> * cifs_create()
> 
>   init state: hashed-negative
>   [d_drop() + d_add()]
>   end state: hashed-positive

IDGI.  Why shouldn't cifs_create() simply do d_instantiate() instead
of that dance, ditto for cifs_tmpfile()?

The only case where you want to change the hashed status is in-lookup
O_CREAT ->atomic_open().  And there it's not d_drop()+d_add() - it's
d_splice_alias().

I'd lift that d_drop() out of cifs_do_create() into the callers and
get rid of it, along with d_add()...