Re: [RFC PATCH v2 0/4] getting rid of busy-wait in shrink_dcache_parent()

Al Viro
2026-04-03T04:43:20Z

On Thu, Apr 02, 2026 at 05:28:58PM -0300, Paulo Alcantara wrote:
> Al Viro <viro@zeniv.linux.org.uk> writes:
>
> > Note: in -next CIFS has grown a local copy of d_mark_tmpfile(), which would need
> > the same modification of sanity checks the original gets in #3/4 here. I wonder
> > if that cifs_d_mark_tmpfile() should be turned into to d_mark_tmpfile_name() and
> > lifted into fs/dcache.c... Anyway, that's a separate story...
>
> Yeah, I would love to have a helper like that and don't mess up with any
> ->d_name outside fs/dcache.c. That's why I'd suggested it in [1].
>
> I'll send a separate patch adding it as soon as I'm done with testing
> O_TMPFILE support in CIFS.
>
> [1] https://lore.kernel.org/r/20260401011153.1757515-1-pc@manguebit.org

OK... IMO we'd be better off with never-rebased branch adding the helper with
cifs branch pulling it and busy-wait branch based on top of the "add the helper"
one - no merge conflicts that way...