Re: [RFC PATCH 05/10] ftrfs: add file operations

Matthew Wilcox
2026-04-13T17:41:58Z

On Mon, Apr 13, 2026 at 07:17:30PM +0200, Aurelien DESBRIERES wrote:
> ... where is this? I only see file_operations and inode_operations. I don't
> see address_space_operations anywhere.

I think you need to fix your email client. Usually on kernel mailing
lists, who said what is indicated by a level of indentation. There's
no indication here that I asked this question.

> You are correct. address_space_operations was described in the commit
> message but never implemented in the patch. This is a bug in the RFC.
>
> Will add ftrfs_aops with readfolio and writepage in v2, and wire it into
> ftrfs_iget() via inode->i_mapping->a_ops.

When you're implementing the address_space_operations, I would recommend
using iomap rather than buffer heads. It's more modern infrastructure,
and there's strong aversion to merging new filesystems that use buffer
heads.