From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9982F3EB81C; Thu, 16 Apr 2026 17:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776360955; cv=none; b=cUVf2OJKDq/XHGpaKWpaEgSt69rUWgeJXBZaI6tNGmH+MbS4T34f86do4+M60cD2mjBnj/bLfzJG+BSczP8iE3djRDDTLGifIPGtyCA/CaBxb8vRX6CTkQCar8+Vj6tDihusWH/Jw5Th0JTzw4leFT5ePIBX8QmmCuKkIU3uXu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776360955; c=relaxed/simple; bh=O4IgEHVmx1g75yBiydYCfYce6Kr1BVy53x3/Vnf7a1o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VY+Am9/VRLDATGYkssQ67xlwKdTV2O+qHpn2HGeCU57NbZDLG0bXek7EpsrJkegX5eAgtXRYqEa7ah4RnZCazGzlPg8l6eRROvmdMDdWHPY+29Pegec+L+EFqK7EsadF+CKVEIFwvqr7R19a15T3bzxsqI7BdytsPwe9QFvViLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VmcouvKz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VmcouvKz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB268C2BCB4; Thu, 16 Apr 2026 17:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776360955; bh=O4IgEHVmx1g75yBiydYCfYce6Kr1BVy53x3/Vnf7a1o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VmcouvKz6JhDfhJWdA+OXAEnQrIHQrSfeX65D5yZQJXwQ6rmiHWuJfO0HKNwTSaVi qI9G9VfaBCjiuOMA0dQPInHWRTxqq/0r3HtSEG1cGRv4UlyxSZ9wPdCRkfK8W0pY+p /3s3mIO3jWD3oI/au2AiM0Xzh+6fRX1UiZS+CQEEX859Y2hObv+j6GUs37reX3oT2A FfpIbjvKJsJSYI6OGs1p6UHJk+rDA+uV0eulAFl7PeegTO50EmwZl7xw2MNd8kOHaf aqXT8jRNkF910vrMCNo2HM66l2SGXMy8VNxYKyFPU06hgJC0jjFQEQAiPNz7oaBc8Z vhR7oHfDCOOCw== From: Jeff Layton Date: Thu, 16 Apr 2026 10:35:23 -0700 Subject: [PATCH v2 22/28] nfsd: send basic file attributes in CB_NOTIFY Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260416-dir-deleg-v2-22-851426a550f6@kernel.org> References: <20260416-dir-deleg-v2-0-851426a550f6@kernel.org> In-Reply-To: <20260416-dir-deleg-v2-0-851426a550f6@kernel.org> To: Alexander Viro , Christian Brauner , Jan Kara , Chuck Lever , Alexander Aring , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , Amir Goldstein Cc: Calum Mackay , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-nfs@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2682; i=jlayton@kernel.org; h=from:subject:message-id; bh=O4IgEHVmx1g75yBiydYCfYce6Kr1BVy53x3/Vnf7a1o=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBp4R3n8MZgmdJA7oHTPC5f0nGZ0qdFtvfvDwo/U WbZ+CHTt5KJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaeEd5wAKCRAADmhBGVaC FdCbEAC/ddTEmsCaoU6cO05JWy0jn6CwJ1puJN9qLhORTTks2H4I5DpmxtyFLGfluJBEQ2GQo29 JL6+U2nEyXcffvVwzTaYd4YYygklwRZzmdyJnWNVWhv2iHy8RJwM/j0ndaLhqjApNFkbjclAQGj +hd9nZ8RIQMn+svTHEKR2FDQc+Kb1J+Te71U9G7qjG3K73YptFnKXT1mtTx51LMz0BEvkLGjDNB QW9S8p7NTjsBVkwEjDknvwF1r/E3ik6HP0I4c2MkiiEKrDHez8trsRZloP+jo3mOuB1NhzxniRS t3Oe2+/pHi7ftoAzxX12ZOhvu+d3MlvG2DksyU3tdErdJvf6VsZKHwPnZBUb+YJJLPGN61AkIhg x3mLMIb9Gh9AwV6wo7+lINPZ4RNvXhc5yEskY1HX9YcUhXfwSa+3nKZXnMoA7HQqp/TALqfqgs0 0lWhdzkctVQPTlYbPDWnCr1mJA4aPEflYKrALxQIHrYaxhdkB74Ue2LbHOpvFWkSSCuUozHEJ9w CLjD8EAo4MtY5fMWIfcjfv7VWd2YnBGZhJjnhP059COPpdlcWsfTVsyssDZqzA++b/q0K3GHIbM 4MLzhorpT/CMj9KAavuXQ3a57m5j6ZDYgcGtt0RUh2Mq15jwEv751bcO87zxguMBWkr/S0smHvv etJZd+C1kJf8Fng== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 In addition to the filename, send attributes about the inode in a CB_NOTIFY event. This patch just adds a the basic inode information that can be acquired via GETATTR. Signed-off-by: Jeff Layton --- fs/nfsd/nfs4xdr.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 91681aea9d7f..f85581ebbd10 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -4104,12 +4104,21 @@ nfsd4_encode_fattr4(struct svc_rqst *rqstp, struct xdr_stream *xdr, goto out; } +#define CB_NOTIFY_STATX_REQUEST_MASK (STATX_BASIC_STATS | \ + STATX_BTIME | \ + STATX_CHANGE_COOKIE) + static bool nfsd4_setup_notify_entry4(struct notify_entry4 *ne, struct xdr_stream *xdr, struct dentry *dentry, struct nfs4_delegation *dp, struct nfsd_file *nf, char *name, u32 namelen) { + struct path path = { .mnt = nf->nf_file->f_path.mnt, + .dentry = dentry }; + struct nfsd4_fattr_args args = { }; uint32_t *attrmask; + __be32 status; + int ret; /* Reserve space for attrmask */ attrmask = xdr_reserve_space(xdr, 3 * sizeof(uint32_t)); @@ -4120,6 +4129,41 @@ nfsd4_setup_notify_entry4(struct notify_entry4 *ne, struct xdr_stream *xdr, ne->ne_file.len = namelen; ne->ne_attrs.attrmask.element = attrmask; + /* FIXME: d_find_alias for inode ? */ + if (!path.dentry || !d_inode(path.dentry)) + goto noattrs; + + /* + * It is possible that the client was granted a delegation when a file + * was created. Note that we don't issue a CB_GETATTR here since stale + * attributes are presumably ok. + */ + ret = vfs_getattr(&path, &args.stat, CB_NOTIFY_STATX_REQUEST_MASK, AT_STATX_SYNC_AS_STAT); + if (ret) + goto noattrs; + + args.change_attr = nfsd4_change_attribute(&args.stat); + + attrmask[0] = FATTR4_WORD0_TYPE | FATTR4_WORD0_CHANGE | + FATTR4_WORD0_SIZE | FATTR4_WORD0_FILEID; + attrmask[1] = FATTR4_WORD1_MODE | FATTR4_WORD1_NUMLINKS | FATTR4_WORD1_RAWDEV | + FATTR4_WORD1_SPACE_USED | FATTR4_WORD1_TIME_ACCESS | + FATTR4_WORD1_TIME_METADATA | FATTR4_WORD1_TIME_MODIFY; + attrmask[2] = 0; + + if (args.stat.result_mask & STATX_BTIME) + attrmask[1] |= FATTR4_WORD1_TIME_CREATE; + + ne->ne_attrs.attrmask.count = 2; + ne->ne_attrs.attr_vals.data = (u8 *)xdr->p; + + status = nfsd4_encode_attr_vals(xdr, attrmask, &args); + if (status != nfs_ok) + goto noattrs; + + ne->ne_attrs.attr_vals.len = (u8 *)xdr->p - ne->ne_attrs.attr_vals.data; + return true; +noattrs: attrmask[0] = 0; attrmask[1] = 0; attrmask[2] = 0; -- 2.53.0