From: Eric Biggers <ebiggers@kernel.org>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
linux-fsdevel@vger.kernel.org, hch@lst.de,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
djwong@kernel.org, Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v8 03/22] ovl: use core fsverity ensure info interface
Date: Tue, 21 Apr 2026 14:44:57 -0700 [thread overview]
Message-ID: <20260421214457.GC37143@quark> (raw)
In-Reply-To: <20260420114714.1621982-4-aalbersh@kernel.org>
On Mon, Apr 20, 2026 at 01:46:50PM +0200, Andrey Albershteyn wrote:
> int ovl_ensure_verity_loaded(const struct path *datapath)
> {
> struct inode *inode = d_inode(datapath->dentry);
> - struct file *filp;
>
> - if (!fsverity_active(inode) && IS_VERITY(inode)) {
> - /*
> - * If this inode was not yet opened, the verity info hasn't been
> - * loaded yet, so we need to do that here to force it into memory.
> - */
> - filp = kernel_file_open(datapath, O_RDONLY, current_cred());
> - if (IS_ERR(filp))
> - return PTR_ERR(filp);
> - fput(filp);
> - }
> + if (fsverity_active(inode))
> + return fsverity_ensure_verity_info(inode);
Not sure whether I should review this version or the version in git, but
both seem wrong. The 'if (!fsverity_active(inode) && IS_VERITY(inode))
{' condition should stay, but fsverity_ensure_verity_info() will need to
gain a !CONFIG_FS_VERITY stub to fix the build error.
- Eric
next prev parent reply other threads:[~2026-04-21 21:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 11:46 [PATCH v8 00/22] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 01/22] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 02/22] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 03/22] ovl: use core fsverity ensure info interface Andrey Albershteyn
2026-04-21 21:44 ` Eric Biggers [this message]
2026-04-20 11:46 ` [PATCH v8 04/22] fsverity: generate and store zero-block hash Andrey Albershteyn
2026-04-21 21:47 ` Eric Biggers
2026-04-20 11:46 ` [PATCH v8 05/22] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 06/22] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 07/22] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 08/22] iomap: teach iomap to read files with fsverity Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 09/22] iomap: introduce iomap_fsverity_write() for writing fsverity metadata Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 10/22] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 11/22] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-04-20 11:46 ` [PATCH v8 12/22] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 13/22] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 14/22] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 15/22] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 16/22] xfs: add fs-verity support Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 17/22] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 18/22] xfs: add fs-verity ioctls Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 19/22] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 20/22] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 21/22] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-04-20 11:47 ` [PATCH v8 22/22] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-04-21 21:43 ` [PATCH v8 00/22] fs-verity support for XFS with post EOF merkle tree Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421214457.GC37143@quark \
--to=ebiggers@kernel.org \
--cc=aalbersh@kernel.org \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox