From: Al Viro <viro@zeniv.linux.org.uk>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dcache: use QSTR() instead of QSTR_INIT()
Date: Wed, 22 Apr 2026 15:34:37 +0100 [thread overview]
Message-ID: <20260422143437.GI3518998@ZenIV> (raw)
In-Reply-To: <20260422123345.100436-2-thorsten.blum@linux.dev>
On Wed, Apr 22, 2026 at 02:33:46PM +0200, Thorsten Blum wrote:
> Drop the hard-coded length arguments and use the simpler QSTR().
... which is not a constant expression. NAK.
QSTR_INIT() is an initializer list for struct qstr; QSTR() is a
compound literal for the same. IOW, its value is an anonymous
local variable with given contents.
C grammar allows both
struct foo x = {.bar = y};
and
struct foo x = (struct foo){.bar = y};
for auto variables, and compiler is able to figure out that they
are equivalent. But the second form is not legal for the static-duration
variables.
next prev parent reply other threads:[~2026-04-22 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:33 [PATCH] dcache: use QSTR() instead of QSTR_INIT() Thorsten Blum
2026-04-22 12:51 ` Jan Kara
2026-04-22 14:34 ` Al Viro [this message]
2026-04-22 15:04 ` Jan Kara
2026-04-22 15:41 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422143437.GI3518998@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox