From: Al Viro <viro@zeniv.linux.org.uk>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] namei: use QSTR() instead of QSTR_INIT() in path_pts
Date: Wed, 22 Apr 2026 15:37:41 +0100 [thread overview]
Message-ID: <20260422143741.GJ3518998@ZenIV> (raw)
In-Reply-To: <20260422123002.99876-3-thorsten.blum@linux.dev>
On Wed, Apr 22, 2026 at 02:30:03PM +0200, Thorsten Blum wrote:
> Drop the hard-coded length argument and use the simpler QSTR().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index c7fac83c9a85..817bba800d7b 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -3617,7 +3617,7 @@ int path_pts(struct path *path)
> */
> struct dentry *parent = dget_parent(path->dentry);
> struct dentry *child;
> - struct qstr this = QSTR_INIT("pts", 3);
> + struct qstr this = QSTR("pts");
>
> if (unlikely(!path_connected(path->mnt, parent))) {
> dput(parent);
NAK. Compound literal is an l-value, so let's just use it:
child = d_hash_and_lookup(parent, &QSTR("pts"));
and to hell with the local variable.
prev parent reply other threads:[~2026-04-22 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:30 [PATCH] namei: use QSTR() instead of QSTR_INIT() in path_pts Thorsten Blum
2026-04-22 12:51 ` Jan Kara
2026-04-22 14:37 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422143741.GJ3518998@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox