From: Al Viro <viro@zeniv.linux.org.uk>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: use QSTR() instead of QSTR_INIT() in fuse_get_dentry
Date: Wed, 22 Apr 2026 15:43:00 +0100 [thread overview]
Message-ID: <20260422144300.GK3518998@ZenIV> (raw)
In-Reply-To: <20260422123911.100979-3-thorsten.blum@linux.dev>
On Wed, Apr 22, 2026 at 02:39:12PM +0200, Thorsten Blum wrote:
> Drop the hard-coded length argument and use the simpler QSTR().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/fuse/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> index deddfffb037f..d224bcba593b 100644
> --- a/fs/fuse/inode.c
> +++ b/fs/fuse/inode.c
> @@ -1113,7 +1113,7 @@ static struct dentry *fuse_get_dentry(struct super_block *sb,
> inode = ilookup5(sb, handle->nodeid, fuse_inode_eq, &handle->nodeid);
> if (!inode) {
> struct fuse_entry_out outarg;
> - const struct qstr name = QSTR_INIT(".", 1);
> + const struct qstr name = QSTR(".");
>
> if (!fc->export_support)
> goto out_err;
>
What's wrong with
err = fuse_lookup_name(sb, handle->nodeid, &QSTR("."), &outarg,
&inode);
to start with?
prev parent reply other threads:[~2026-04-22 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:39 [PATCH] fuse: use QSTR() instead of QSTR_INIT() in fuse_get_dentry Thorsten Blum
2026-04-22 14:43 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422144300.GK3518998@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox