From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF923BE64B; Thu, 23 Apr 2026 13:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776949945; cv=none; b=Gy0xywRp94AEQdVUoRYKnTnGtEy+8CeKFtRi0r7l6ptCBN3WGbks6M0CvknLJ2z+H+5UJyHnrFe9CKQSlBgslpEbNzVevYVEkd/khrYNNIrZKXHwnTipBoqf1hMTys62AlGMEQnsGE1TzucYMKJdnZaeJjV+BhvbTLsXFzGsYxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776949945; c=relaxed/simple; bh=8UqRyDDayDThBQIQ3JhVpzhStC9FLBOMKCqvs54Qc/w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W/OuehlbvGfAHe/7Ac/86BHASN8kkc5SoxqkoAJ410klhQhc7uT9+DKJ/psn8+IlO8t30zdeKdBuaiR7F3wp45rCNW3NxQZpUAsMC3AdDHqZu1s4me7LWDV6yda/ZgTh49RJGwGuCZHBH3jjyCKKU81Z/EFD37IV5HCDCt03Pbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h2KYTlGy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h2KYTlGy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82248C2BCB4; Thu, 23 Apr 2026 13:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776949945; bh=8UqRyDDayDThBQIQ3JhVpzhStC9FLBOMKCqvs54Qc/w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=h2KYTlGyNhnldToZ6KBhUMCCCZfpY6jBCDpO2/HSziszBWjHNEKeA/Y/tJQyGLBbc eIiKC7rIzdOQuu4yZkE0ReHAaqqZkQ/7atH1wYkXOfCt+fOrGNDMQzToYKivIFTBGh PwZwWsVBMTkfjxb2f9Ddn+cdnzSlRP1XLlz2KR/6bLW6WbdSQcfSzmIV6tmRaqyVDB ZSYqdrDROlpbtFcpZxxUpT8Af23YUxh37JMItVAWwY2U10lS9HO8aKoW9YQ4buS3fU nbpm4fEfuVgS7+ZEHQf7BSqN/9aYI+UqosP5IHbi6qn99J0FtQ9XY2v6b5f/G3u4QF TdONWt7dY/ZTw== From: Chuck Lever Date: Thu, 23 Apr 2026 09:12:04 -0400 Subject: [PATCH v10 01/17] fs: Move file_kattr initialization to callers Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-case-sensitivity-v10-1-c385d674a6cf@oracle.com> References: <20260423-case-sensitivity-v10-0-c385d674a6cf@oracle.com> In-Reply-To: <20260423-case-sensitivity-v10-0-c385d674a6cf@oracle.com> To: Al Viro , Christian Brauner , Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com, almaz.alexandrovich@paragon-software.com, slava@dubeyko.com, glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu, adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org, pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org, senozhatsky@chromium.org, Chuck Lever , "Darrick J. Wong" X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3551; i=chuck.lever@oracle.com; h=from:subject:message-id; bh=bvYDki24delKK+bT1VFKda9bd9+KlESsOU2uc3t1XJU=; b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp6hqzekdwvJSHCsI01uU5bkBgDmfma+vhsoir1 hPF4SjFi6qJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCaeoaswAKCRAzarMzb2Z/ l46TD/9pmKN2J9EUJXdHjWz8EwTvPYNEbnA1RJwnkVzDTI1/ByZZNw3LwtPEJwex/Oke8czPW41 2+KHN98jVc/LGETLoymSjYnqQe6x1ghlyRPAKOEDlwR78kERwpBVooRVN0PfnqglXF4C+rchO2c zfiYK7pOFpAhK3TCrUo0xic935TkyMvSQUI0rm3EaT7IwNHKk4XEFaLD19yL+JRatKxFxdf2bBy ObB9ErgS+g+bTdB9nneWa/wCOG2c4eDaMO6uCcKt1lU1zDCrvP3NCF2e7lHKiWZ+bDBJ6Xaw2/v ePlGjK9vGI4uFju+jAQ+VUwjEH0fdb164DC+pCdFfTe96U0wTXzkm3ikvc+NirIC0oGwI4OQrLq A44LvYPuXhpQl3PcDYEQSPH+8DutgHmo36uAD5YtirLorq60YZWI3ifM2faHr5J0JxrpetChpvV HQqK5FVOlyGUyowa5bOdnbOYeHXoXZEqrgF+g55FC7Q9gbbczjZC4SDn5RmNXkTq34IyItu1hdm ze9TZY7wo12trubTaefnit7n8wFMhjVJS+wZ/1DTREVk1JTdxsm3BA+moJh2aOlDHtq6Mam8HoM jDrAoGKgtsLGv+V7cSpCukcY2Hv05GCaGV4K1O6z5EVzPHY6iglTTzaEa5CIywY/5B4Ps16+R3/ ZYVIIKT+yY8h0cw== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 From: Chuck Lever fileattr_fill_xflags() and fileattr_fill_flags() memset the entire file_kattr struct before populating select fields, so callers cannot pre-set fields in fa->fsx_xflags without having their values clobbered. Darrick Wong noted that a function named "fill_xflags" touching more than xflags forces callers to know implementation details beyond its apparent scope. Drop the memset from both fill functions and initialize at the entry points instead: ioctl_setflags(), ioctl_fssetxattr(), the file_setattr() syscall, and xfs_ioc_fsgetxattra() now declare fa with an aggregate initializer. ioctl_getflags(), ioctl_fsgetxattr(), and the file_getattr() syscall already aggregate-initialize fa to pass flags_valid/fsx_valid hints into vfs_fileattr_get(). Subsequent patches rely on this so that ->fileattr_get() handlers can set case-sensitivity flags (FS_XFLAG_CASEFOLD, FS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags before the fill functions run. Suggested-by: Darrick J. Wong Reviewed-by: Jan Kara Reviewed-by: Darrick J. Wong Signed-off-by: Chuck Lever --- fs/file_attr.c | 12 ++++-------- fs/xfs/xfs_ioctl.c | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/fs/file_attr.c b/fs/file_attr.c index da983e105d70..f429da66a317 100644 --- a/fs/file_attr.c +++ b/fs/file_attr.c @@ -15,12 +15,10 @@ * @fa: fileattr pointer * @xflags: FS_XFLAG_* flags * - * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All - * other fields are zeroed. + * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). */ void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags) { - memset(fa, 0, sizeof(*fa)); fa->fsx_valid = true; fa->fsx_xflags = xflags; if (fa->fsx_xflags & FS_XFLAG_IMMUTABLE) @@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags); * @flags: FS_*_FL flags * * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags). - * All other fields are zeroed. */ void fileattr_fill_flags(struct file_kattr *fa, u32 flags) { - memset(fa, 0, sizeof(*fa)); fa->flags_valid = true; fa->flags = flags; if (fa->flags & FS_SYNC_FL) @@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp) { struct mnt_idmap *idmap = file_mnt_idmap(file); struct dentry *dentry = file->f_path.dentry; - struct file_kattr fa; + struct file_kattr fa = {}; unsigned int flags; int err; @@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp) { struct mnt_idmap *idmap = file_mnt_idmap(file); struct dentry *dentry = file->f_path.dentry; - struct file_kattr fa; + struct file_kattr fa = {}; int err; err = copy_fsxattr_from_user(&fa, argp); @@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename, struct path filepath __free(path_put) = {}; unsigned int lookup_flags = 0; struct file_attr fattr; - struct file_kattr fa; + struct file_kattr fa = {}; int error; BUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0); diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 46e234863644..ed9b4846c05f 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -517,7 +517,7 @@ xfs_ioc_fsgetxattra( xfs_inode_t *ip, void __user *arg) { - struct file_kattr fa; + struct file_kattr fa = {}; xfs_ilock(ip, XFS_ILOCK_SHARED); xfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa); -- 2.53.0