From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
Paulo Alcantara <pc@manguebit.org>,
netfs@lists.linux.dev, linux-afs@lists.infradead.org,
linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/4] netfs: Yet further miscellaneous fixes
Date: Thu, 23 Apr 2026 23:22:03 +0100 [thread overview]
Message-ID: <20260423222209.3054909-1-dhowells@redhat.com> (raw)
Hi Christian,
Here are yet more miscellaneous fixes for netfslib, one found by Mark Brown
when integrating linux-next and the rest found by Sashiko.dev's AI review[1]:
(1) Fix a return statement that should have been removed from
netfs_read_sizes() and only happens on 32-bit SMP.
(2) Fix read and write result collection use barriering correctly to
access a request's subrequest lists without taking a lock.
This adds list_add_tail_release() and list_first_entry_acquire() to
appropriate incorporate barriering into some list functions.
(3) Fix afs_get_link() to take the vnode->validate_lock around
afs_read_single() to prevent a race with another caller of
afs_get_link() also trying to read the symlink content.
(4) Fix the RCU handling of symlinks in RCU pathwalk. The problems were
that afs_get_link() didn't use proper RCU pointer dereferencing and
that AFS symlinks can be updated remotely, potentially causing the
buffer memory to be changed.
These are applied on top of your vfs.fixes branch. Patch 1 should fix the
problem in linux-next integration.
The patches can also be found here:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes
Thanks,
David
[1] https://sashiko.dev/#/patchset/20260326104544.509518-1-dhowells%40redhat.com
base-commit: 986563b3799fee66965811df3f46f5bb76736084
David Howells (4):
netfs: Fix wrong return from netfs_read_sizes() on 32-bit SMP arches
netfs: Fix missing barriers when accessing stream->subrequests
locklessly
afs: Fix afs_get_link() to take validate_lock around afs_read_single()
afs: Fix RCU handling of symlinks in RCU pathwalk
fs/afs/Makefile | 1 +
fs/afs/dir.c | 33 ++++--
fs/afs/fsclient.c | 4 +-
fs/afs/inode.c | 96 +---------------
fs/afs/internal.h | 35 ++++--
fs/afs/symlink.c | 242 +++++++++++++++++++++++++++++++++++++++
fs/afs/yfsclient.c | 4 +-
fs/netfs/buffered_read.c | 9 +-
fs/netfs/direct_read.c | 15 +--
fs/netfs/internal.h | 3 +
fs/netfs/read_collect.c | 4 +-
fs/netfs/read_single.c | 12 +-
fs/netfs/write_collect.c | 4 +-
fs/netfs/write_issue.c | 3 +-
include/linux/list.h | 37 ++++++
include/linux/netfs.h | 1 -
16 files changed, 358 insertions(+), 145 deletions(-)
create mode 100644 fs/afs/symlink.c
next reply other threads:[~2026-04-23 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 22:22 David Howells [this message]
2026-04-23 22:22 ` [PATCH 1/4] netfs: Fix wrong return from netfs_read_sizes() on 32-bit SMP arches David Howells
2026-04-23 22:22 ` [PATCH 2/4] netfs: Fix missing barriers when accessing stream->subrequests locklessly David Howells
2026-04-23 22:22 ` [PATCH 3/4] afs: Fix afs_get_link() to take validate_lock around afs_read_single() David Howells
2026-04-23 22:22 ` [PATCH 4/4] afs: Fix RCU handling of symlinks in RCU pathwalk David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423222209.3054909-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=christian@brauner.io \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox