From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5319F37B413 for ; Thu, 23 Apr 2026 22:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776982953; cv=none; b=nEQzI4/imWA401PzaQ1P6Z8mEculd/k+v+P1Vj2rN9ruNKSmu5DYgJHhyNtmSZ4LuZudGc5QyOAkzD8iAkQyAlVnYmYXC8NjBnqq7hguPbH2Mz4Y5dRA3/QrjN7W/q2+MoJ6+FYs62+TE3ryMjG4uMWzRzTsSOeAlCLuzKfO29c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776982953; c=relaxed/simple; bh=EQpPMiLagPYSIVsb0YWyJHfB16hbO4DByLA6fMjT7yY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=apBEXXgm7IBB3kx5YB3uUBqWv9RtHe+LWOc3cWfMFiDaZpLKJH7Hc2d13K4ZxNeymmbLohSMJdgjuAYlvnDYfOM4kMHoaUHdx9w4dr1fMyYDJTbHMZme770bYxgj1OH7/zrnWU50VEoWuU0URqKkmGPNiephLYU7cCnHsKqV/U4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=adAn5/iw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="adAn5/iw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776982951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=600g6oafpsmNXEPuDP1fqAUAuRGwYq58jCdzRtTHVzs=; b=adAn5/iwKphAR4Yo6g/A3/4pYaQaMtd6U85m+e34T3vuQjje1jCV0wXJQFXRYr8vKu5fJy FkXZJ3gb8STLTTS8fx1+Dg2vdIOneb1t2w0LrvwIhfW6TQ9f9y3XKRogq0ZkOR/ym3cGFY Xqkl4rLC5BBaDrK89iydiAfUNermbEk= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-GJn_nIQFO-qJAJAnoBfq3A-1; Thu, 23 Apr 2026 18:22:28 -0400 X-MC-Unique: GJn_nIQFO-qJAJAnoBfq3A-1 X-Mimecast-MFC-AGG-ID: GJn_nIQFO-qJAJAnoBfq3A_1776982946 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E7D519560BB; Thu, 23 Apr 2026 22:22:26 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.48.17]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2CE67180047F; Thu, 23 Apr 2026 22:22:21 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Paulo Alcantara , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown , Christian Brauner Subject: [PATCH 1/4] netfs: Fix wrong return from netfs_read_sizes() on 32-bit SMP arches Date: Thu, 23 Apr 2026 23:22:04 +0100 Message-ID: <20260423222209.3054909-2-dhowells@redhat.com> In-Reply-To: <20260423222209.3054909-1-dhowells@redhat.com> References: <20260423222209.3054909-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Fix netfs_read_sizes() for 32-bit SMP arches to not have a return value. Fixes: 756f72b6d8db ("netfs: Fix potential for tearing in ->remote_i_size and ->zero_point") Reported-by: Mark Brown Closes: https://lore.kernel.org/r/aeoIAXzqh0n54mxl@sirena.org.uk Signed-off-by: David Howells cc: Christian Brauner cc: Paulo Alcantara cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- include/linux/netfs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/netfs.h b/include/linux/netfs.h index d72bc2f11734..ad394c088578 100644 --- a/include/linux/netfs.h +++ b/include/linux/netfs.h @@ -669,7 +669,6 @@ static inline void netfs_read_sizes(const struct netfs_inode *ictx, *remote_i_size = ictx->_remote_i_size; *zero_point = ictx->_zero_point; } while (read_seqcount_retry(&inode->i_size_seqcount, seq)); - return zero_point; #elif BITS_PER_LONG==32 && defined(CONFIG_PREEMPTION) unsigned long long zero_point;