From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF953DA5B9 for ; Mon, 27 Apr 2026 15:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777304908; cv=none; b=DWv2f5vNKR+bOV6Cw6No8PFccpAbfIju03gvAnHUQYiZ3czvx4AF63n81ZaqYv1/nmhDhAwpH3Ve1fIySmaCyarM8Da8EkaqmXOLiuqa6voYWLKPrn7NKpWJrLYRkkJlaZ5iPDzbElFnF0EoMfncTXY2Xb8rXxtXGMKZdYO4oBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777304908; c=relaxed/simple; bh=r6K9iFCwGOBbvUFsNm3usyWKYBGnIBFG0RK8j8V5wJE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZhnuNeqGDF3zSq7FcDH4i4Pr4P6eG6YXfK6rz+PClU0Cf5BjcWt4uJKUc3a1MOzaNz/qDMa/WQHLDV8+nOduwBBnr/t70xZYuVyjtcMSm/Ehh5AJNf6x+IgJ2TeaHTIm/0dHasx/fzF3Y0W0sl5LUK56c2X/ebt2+voiOGY3QFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TcS7TW64; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TcS7TW64" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777304906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8TreMojEQ0wPuyO6zSmrQCQs0j8kwVy3C2ZGai7LkE=; b=TcS7TW648rHVPtwM2Eb+/SwvUW1IDk19/8wjWFVeqJ2nSqDQcVNk69sUZCAtNuB1EgXqkv tdvIzh/0u0D0BZ5aae2raZZAkFI1e96pb2MNykCuYHnA5mA8R4aBS8dsVxED8szjHj2qiB QgwG4UWTpTK3VjAGZLoE0+3p5S6w1nw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-ruZpO2nZNXevnvPOO4C5GA-1; Mon, 27 Apr 2026 11:48:21 -0400 X-MC-Unique: ruZpO2nZNXevnvPOO4C5GA-1 X-Mimecast-MFC-AGG-ID: ruZpO2nZNXevnvPOO4C5GA_1777304898 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B94C3195608B; Mon, 27 Apr 2026 15:48:18 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.32.126]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BDD9719560AB; Mon, 27 Apr 2026 15:48:15 +0000 (UTC) From: David Howells To: Christian Brauner Cc: David Howells , Paulo Alcantara , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: [PATCH v4 20/22] netfs: Fix netfs_read_folio() to wait on writeback Date: Mon, 27 Apr 2026 16:46:35 +0100 Message-ID: <20260427154639.180684-21-dhowells@redhat.com> In-Reply-To: <20260427154639.180684-1-dhowells@redhat.com> References: <20260427154639.180684-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Fix netfs_read_folio() to wait for an ongoing writeback to complete so that it can trust the dirty flag and whatever is attached to folio->private (folio->private may get cleaned up by the collector before it clears the writeback flag). Fixes: ee4cdf7ba857 ("netfs: Speed up buffered reading") Closes: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Paulo Alcantara cc: Matthew Wilcox cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/netfs/buffered_read.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c index ec576d840594..5e299237c9ec 100644 --- a/fs/netfs/buffered_read.c +++ b/fs/netfs/buffered_read.c @@ -508,6 +508,8 @@ int netfs_read_folio(struct file *file, struct folio *folio) struct netfs_inode *ctx = netfs_inode(mapping->host); int ret; + folio_wait_writeback(folio); + if (folio_test_dirty(folio)) return netfs_read_gaps(file, folio);