From: "Darrick J. Wong" <djwong@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3] docs: add guidelines for submitting new filesystems
Date: Mon, 27 Apr 2026 14:47:35 -0700 [thread overview]
Message-ID: <20260427214735.GM7765@frogsfrogsfrogs> (raw)
In-Reply-To: <CAOQ4uxg=Yi5eOPshMsA9HV6vrs9SnZ3XFvoqjR4s-AJQPX4FSw@mail.gmail.com>
On Mon, Apr 27, 2026 at 09:30:06PM +0200, Amir Goldstein wrote:
> > > +Be testable
> > > + The filesystem must be testable in a meaningful way. The
> > > + `fstests <https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git>`_
> > > + framework (also known as xfstests) is the standard testing infrastructure
> >
> > It's been known as 'fstests' (without the leading 'x') ever since other
> > filesystems started using it for their QA.
>
> Sorry, I couldn't parse the requested fix.
> The document already refers to it as 'fstests'.
> I'd rather just drop "(also known as xfstests)".
The '(also known as xfstests)' part was what I was complaining abou...
oh, that's some weird markdown thing. Never mind.
Dropping the whole phrase also works.
--D
> The aliases of fstests and their history are out of scope for this doc.
> The repo URL link does not leave any room for confusion.
>
> Christian, assuming that we all agree on this, could you make this change?
>
> >
> > With that fixed,
> > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> >
>
> Thanks,
> Amir.
prev parent reply other threads:[~2026-04-27 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:52 [PATCH v3] docs: add guidelines for submitting new filesystems Amir Goldstein
2026-04-22 13:04 ` Jan Kara
2026-04-27 15:05 ` Christian Brauner
2026-04-27 15:48 ` Darrick J. Wong
2026-04-27 19:30 ` Amir Goldstein
2026-04-27 21:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260427214735.GM7765@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox