From: Christoph Hellwig <hch@lst.de>
To: "Pankaj Raghav (Samsung)" <pankaj.raghav@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: pass a minsize argument to bio_iov_iter_bounce
Date: Mon, 4 May 2026 06:58:44 +0200 [thread overview]
Message-ID: <20260504045844.GA9353@lst.de> (raw)
In-Reply-To: <jgzzl7e6qzea5ohma2tdma2rndlaj4ouohsiwohpz22w3aiqvp@czndpvnggd3q>
On Fri, May 01, 2026 at 02:46:51PM +0200, Pankaj Raghav (Samsung) wrote:
> On Thu, Apr 30, 2026 at 03:20:04PM +0200, Christoph Hellwig wrote:
> > When bouncing for block size > PAGE_SIZE file systems, the bio needs to
> > be big enough to fit an entire block.
>
> We set the alignment to fs_block_size when IOMAP_DIO_FSBLOCK_ALIGNED is
> set. And we always set IOMAP_DIO_FSBLOCK_ALIGNED in btrfs for dio
> reads/writes. IIUC, it was added to support bs > PS block sizes in btrfs.
> But in XFS, we set it only for CoW inodes (xfs_is_always_cow_inode is true).
Yes, I ran into this with zoned XFS on large block size.
>
> The commit message seems to indicate this is needed for all filesystems
> that support bs > PS configurations. Am I missing something here?
No, the commit message could be a bit more exact.
next prev parent reply other threads:[~2026-05-04 4:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 13:20 fix block layer bounce buffering for block size > PAGE_SIZE Christoph Hellwig
2026-04-30 13:20 ` [PATCH 1/2] block: pass a minsize argument to bio_iov_iter_bounce Christoph Hellwig
2026-04-30 13:30 ` Matthew Wilcox
2026-04-30 14:53 ` Christoph Hellwig
2026-05-01 12:46 ` Pankaj Raghav (Samsung)
2026-05-04 4:58 ` Christoph Hellwig [this message]
2026-04-30 13:20 ` [PATCH 2/2] block: align down bounces bios Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-05-07 5:01 fix block layer bounce buffering for block size > PAGE_SIZE v2 Christoph Hellwig
2026-05-07 5:01 ` [PATCH 1/2] block: pass a minsize argument to bio_iov_iter_bounce Christoph Hellwig
2026-05-07 11:36 ` Pankaj Raghav (Samsung)
2026-05-08 8:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504045844.GA9353@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pankaj.raghav@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox