From: Eric Biggers <ebiggers@kernel.org>
To: Colin Walters <walters@verbum.org>
Cc: fsverity@lists.linux.dev,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] ovl: fix verity lazy-load guard broken by fsverity_active() semantic change
Date: Tue, 5 May 2026 14:00:16 -0700 [thread overview]
Message-ID: <20260505210016.GA3895@quark> (raw)
In-Reply-To: <6630d44f-967d-41f0-81ce-6958b371465a@app.fastmail.com>
On Tue, May 05, 2026 at 02:15:58PM -0400, Colin Walters wrote:
> Commit f77f281b6118 ("fsverity: use a hashtable to find the fsverity_info")
> that broke `ovl_ensure_verity_loaded` in the case when the inode was not in core.
>
> The APIs here are in my opinion now confusing, but this patch intentionally
> aims for a minimized fix by using `fsverity_get_info()` which ensures
> the hash table is loaded.
>
> Fixes: f77f281b6118 ("fsverity: use a hashtable to find the fsverity_info")
> Cc: stable@vger.kernel.org
> Link: https://github.com/bootc-dev/bootc/issues/2174
> Signed-off-by: Colin Walters <walters@verbum.org>
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
I can take this through the fsverity tree as a fix for 7.1. Amir, let
me know if you'd prefer to take it instead.
- Eric
next prev parent reply other threads:[~2026-05-05 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 18:15 [PATCH] ovl: fix verity lazy-load guard broken by fsverity_active() semantic change Colin Walters
2026-05-05 21:00 ` Eric Biggers [this message]
2026-05-05 22:46 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505210016.GA3895@quark \
--to=ebiggers@kernel.org \
--cc=amir73il@gmail.com \
--cc=fsverity@lists.linux.dev \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox