From: "Darrick J. Wong" <djwong@kernel.org>
To: bernd@bsbernd.com
Cc: joannelkoong@gmail.com, neal@gompa.dev,
fuse-devel@lists.linux.dev, linux-fsdevel@vger.kernel.org,
miklos@szeredi.hu
Subject: [PATCH 3/2] mount_util: fix mount_flags entries for MS_RDONLY
Date: Tue, 5 May 2026 16:09:30 -0700 [thread overview]
Message-ID: <20260505230930.GD7739@frogsfrogsfrogs> (raw)
In-Reply-To: <177795853450.1133476.8692790530314969678.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
MS_RDONLY maps to MOUNT_ATTR_RDONLY in the new fsmount API, but the
table omitted that. Fix that.
Fixes: 0d7e72541564a5 ("Unify mount flag structures and remove redundant is_mount_attr field")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
lib/mount_util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/mount_util.c b/lib/mount_util.c
index 1a0aec9bfe1a70..7ab1dba91e28e3 100644
--- a/lib/mount_util.c
+++ b/lib/mount_util.c
@@ -110,8 +110,8 @@
const struct mount_flags mount_flags[] = {
/* opt flag on safe mount_attr */
-{"rw", MS_RDONLY, 0, 1, 0}, /* fsconfig */
-{"ro", MS_RDONLY, 1, 1, 0}, /* fsconfig */
+{"rw", MS_RDONLY, 0, 1, MOUNT_ATTR_RDONLY}, /* fsconfig */
+{"ro", MS_RDONLY, 1, 1, MOUNT_ATTR_RDONLY}, /* fsconfig */
{"suid", MS_NOSUID, 0, 0, MOUNT_ATTR_NOSUID}, /* fsmount */
{"nosuid", MS_NOSUID, 1, 1, MOUNT_ATTR_NOSUID}, /* fsmount */
{"dev", MS_NODEV, 0, 1, MOUNT_ATTR_NODEV}, /* fsmount */
next prev parent reply other threads:[~2026-05-05 23:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 5:21 [PATCHBOMB] libfuse: various fixes for new mount code Darrick J. Wong
2026-05-05 5:23 ` [PATCHSET 1/2] libfuse: new mount API and SYNC_INIT fixes Darrick J. Wong
2026-05-05 5:23 ` [PATCH 1/2] libfuse: don't use SYNC_INIT unless asked for Darrick J. Wong
2026-05-05 7:30 ` Bernd Schubert
2026-05-05 8:17 ` Bernd Schubert
2026-05-05 16:27 ` Darrick J. Wong
2026-05-05 16:44 ` [PATCH v1.1 " Darrick J. Wong
2026-05-05 20:02 ` Bernd Schubert
2026-05-05 22:08 ` Darrick J. Wong
2026-05-05 22:29 ` Bernd Schubert
2026-05-05 23:03 ` Darrick J. Wong
2026-05-05 23:10 ` [PATCH v1.2 " Darrick J. Wong
2026-05-05 5:23 ` [PATCH 2/2] libfuse: always send the subtype to the kernel when using fsconfig() Darrick J. Wong
2026-05-05 7:41 ` Bernd Schubert
2026-05-05 16:38 ` Darrick J. Wong
2026-05-05 23:09 ` Darrick J. Wong [this message]
2026-05-05 5:23 ` [PATCHSET 2/2] libfuse: new mount service container fixes Darrick J. Wong
2026-05-05 5:24 ` [PATCH 01/10] util/mount.fuse.c: loop in waitpid Darrick J. Wong
2026-05-05 5:24 ` [PATCH 02/10] fuse_service: handle weird behavior during SCM_RIGHTS fd transfers Darrick J. Wong
2026-05-05 5:24 ` [PATCH 03/10] examples: improve documentation of the new systemd service fuse servers Darrick J. Wong
2026-05-05 5:24 ` [PATCH 04/10] example/single_file: sync backing fd when statx wants us to fsync Darrick J. Wong
2026-05-05 5:25 ` [PATCH 05/10] example/single_file: fix ctime handling Darrick J. Wong
2026-05-05 5:25 ` [PATCH 06/10] libfuse: fix cppcheck complaints about constifying pointers Darrick J. Wong
2026-05-05 5:25 ` [PATCH 07/10] libfuse: fix cppcheck complaints about constifying pointers in user-visible ABI Darrick J. Wong
2026-05-05 5:25 ` [PATCH 08/10] util: fix cppcheck complaints about constifying pointers Darrick J. Wong
2026-05-05 5:26 ` [PATCH 09/10] fuser_conf: fix cppcheck complaints Darrick J. Wong
2026-05-05 5:26 ` [PATCH 10/10] example: fix cppcheck complaints about constifying pointers Darrick J. Wong
2026-05-06 21:27 ` [PATCHSET 2/2] libfuse: new mount service container fixes Bernd Schubert
2026-05-06 21:36 ` Bernd Schubert
2026-05-05 5:26 ` [GIT PULL 1/2] libfuse: new mount API and SYNC_INIT fixes Darrick J. Wong
2026-05-05 5:26 ` [GIT PULL 2/2] libfuse: new mount service container fixes Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505230930.GD7739@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=bernd@bsbernd.com \
--cc=fuse-devel@lists.linux.dev \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neal@gompa.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox