From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E4D27CCE0 for ; Fri, 8 May 2026 02:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778208764; cv=none; b=XJbftyA6eg1rO7PhbszuNmNOacBqhKqHN82m+O/+ZnuqhnGTYD9RmTNxzdoYxlQZoCwsLgPqW5Uj12/LE2gii84JLdADb5EJy/LeNUn0tGFHKYBh8VInGF7S+g2VfEXRvandNczPh3qW2B6dz18NBQsNTYGP+yxk/7Zu11RfeH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778208764; c=relaxed/simple; bh=TxFqk8i+4b6dEi3VGsPCyT6UMh99EcS5+9xa5h8ZEmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DxZiRkBu9RrWJ6w0i9/sbnsgwdRWW0tUESUAXRR3mJs/L5Hi4h7ZETQn9DaK1jgN0wsBe8TkGOlsdJaDUwXUDsVSqDUsfoM9vZF7U4jm9nn9Dx4M9c1WV+M0pOhK+3nKK9Toms0FnJlCJiJnQMh6cUpqPdgs/9AeqLttZ2uoimU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qd1qlXli; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qd1qlXli" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6634bb959a2so2052388a12.1 for ; Thu, 07 May 2026 19:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778208762; x=1778813562; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GXo8YRKGAQ0gGQsS3CnfFEP5ggHykysOGobJBcjxhWg=; b=Qd1qlXliLfZ849CmHV+HjAVyD4ZF5SV6Cmf29ECSofNbg0K8Yu6jMtNHVO3Zxd/AMH MuABcvUrioFKZkHOjKAy5eJTKaGKk1F4/u+jOtUvGwdFeJ73NiKhSrEgZVpXe+jGuk6v /ikzuFTMRJUnG55XQIp8Vt3E/fnZcBWQCZFqXMv9Dw+FVPD/gStCsr8T5H+3zo31l3AR HNDbdoeijQBjpXIIEaWA3tEUbkoUSaqpz7LY5ztn5d/m1Sb3XUJg45vFL+Rx6HXGNHfp ENkmpB0oJ/kHEi9Ibl4I4MCbhhgMWGHuaie4h0ZMbtLRNmxk3GRCGyjuDuqFAr4vzts5 HmHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778208762; x=1778813562; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GXo8YRKGAQ0gGQsS3CnfFEP5ggHykysOGobJBcjxhWg=; b=eLcga4QpVNK9/+rtF9Wdrb0lqjOHS4q5dHGa5+bu0rE+LUI+ToT1ZV731HjGBXIFh6 cDLI7BOY/LGl8pPMdXyRGyXY7ESeiOGVFudo0tTEa8HptxXsmf4h5Wg3BrjdQXWozL1/ 6RhUkzX9aNwv/kIVDfrlQn6LLJTYFQv+hJdceFVN9Nd64V5nJk4BG274Ioxh3b1ytKTk /97+83BmsocGU/Ex8UoJg7co8shQ/wIlf/cdhrv8Qi+BdU8ND3nXosmoG8d+pVpLbbco rORVp/i034wE+Ow51YcBaB9okDrkQ1cYCO2d3EyzUAip5QsUrHftks7EaCh/N6HcXB1i 15kw== X-Forwarded-Encrypted: i=1; AFNElJ+xJVMT0Ol5YnN42mNSR+g9sQfNIXQg6X1Yin5Nn3hCHuV/CiHGz+ie494vppTokp5Pj0GqZAnTJB9oj2uN@vger.kernel.org X-Gm-Message-State: AOJu0Yz5AH/PCsqJ21EF9s5zy+GIWrvegUuhK+eiSoi8jl4BvN8O+u5r RDxMuocHLg8Fah7uUS7lhtgR6UjIZLWBMtKjJNCJlZtrYbjX/vuHI3G7 X-Gm-Gg: Acq92OFwScsHvBUFzbNdervpRETO0AzYvlCtNTb+i2KCrZrxnDjN3WuimuKejBNy7Ru /B8fW4UMG3svIDTDdDk590iIuCmTmR2M+LfCQtzfkDiwJVjc0sxbZVmw2+KgfKDKXW+F5SJoofv DI4Q4L81iuKuDnhdgSLSuG3M9wjPlMDUz8C5wo/+3f74kTvjhdgfMH37AZH6UlxiNGCerRcLqVs U/cDIJa5IdgmClRaPC1ZPkqBPsBk6T7FrM7bTWDOsgVkOcTcbB64yYreYn5tPnKyq5Nzo//UrGb SV5DRDu3az1Hy/uIPCNApa+3n+A2uXBZ5iVMB3VTZE8GMVPsfFkKiub0jr12M/ky03eOilTCpvl MU95J91Cw9rgaNc16kv4tKNM6CUrB0ZsOMJNK3a/y2YIuo+3Gxs/DOCg70q5thNKmt3mv1Uu9G1 Y2urYkafsgVvB/QxL5t4NRwzPNblMcByAn X-Received: by 2002:a50:fa8d:0:b0:676:988e:8eb6 with SMTP id 4fb4d7f45d1cf-67d648a9ed2mr3977298a12.26.1778208761525; Thu, 07 May 2026 19:52:41 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67ef0e1a221sm102651a12.24.2026.05.07.19.52.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 May 2026 19:52:40 -0700 (PDT) Date: Fri, 8 May 2026 02:52:39 +0000 From: Wei Yang To: Zi Yan Cc: Andrew Morton , David Hildenbrand , "Matthew Wilcox (Oracle)" , Song Liu , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , Jan Kara , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 05/14] mm: remove READ_ONLY_THP_FOR_FS Kconfig option Message-ID: <20260508025239.ooz5kc5a3n372ebb@master> Reply-To: Wei Yang References: <20260429152924.727124-1-ziy@nvidia.com> <20260429153538.727855-1-ziy@nvidia.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260429153538.727855-1-ziy@nvidia.com> User-Agent: NeoMutt/20170113 (1.7.2) On Wed, Apr 29, 2026 at 11:35:28AM -0400, Zi Yan wrote: >After removing READ_ONLY_THP_FOR_FS check in file_thp_enabled(), >khugepaged and MADV_COLLAPSE can run on FSes with PMD THP pagecache >support even without READ_ONLY_THP_FOR_FS enabled. Remove the Kconfig first >so that no one can use READ_ONLY_THP_FOR_FS as upcoming commits remove >mapping->nr_thps, which its safe guard mechanism relies on. > >Signed-off-by: Zi Yan >Reviewed-by: Lorenzo Stoakes (Oracle) >Acked-by: David Hildenbrand (Arm) >Reviewed-by: Baolin Wang >--- > mm/Kconfig | 11 ----------- > 1 file changed, 11 deletions(-) > >diff --git a/mm/Kconfig b/mm/Kconfig >index e221fa1dc54d0..27dc5b0139ba6 100644 >--- a/mm/Kconfig >+++ b/mm/Kconfig >@@ -936,17 +936,6 @@ config THP_SWAP > > For selection by architectures with reasonable THP sizes. > >-config READ_ONLY_THP_FOR_FS >- bool "Read-only THP for filesystems (EXPERIMENTAL)" >- depends on TRANSPARENT_HUGEPAGE >- >- help >- Allow khugepaged to put read-only file-backed pages in THP. >- >- This is marked experimental because it is a new feature. Write >- support of file THPs will be developed in the next few release >- cycles. >- Hi, I see hugepage_enabled() in khugepaged.c still use READ_ONLY_THP_FOR_FS. > config NO_PAGE_MAPCOUNT > bool "No per-page mapcount (EXPERIMENTAL)" > help >-- >2.53.0 > -- Wei Yang Help you, Help me