From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org, Junxi Qian <qjx1298677004@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Greg KH <gregkh@linuxfoundation.org>,
Joanne Koong <joannelkoong@gmail.com>
Subject: Re: [PATCH] fuse: fix writeback array overflow when max_pages is one
Date: Mon, 11 May 2026 12:38:51 +0200 [thread overview]
Message-ID: <20260511-trotz-stopfen-bcbd74d26b06@brauner> (raw)
In-Reply-To: <20260506122415.205340-1-qjx1298677004@gmail.com>
On Wed, 06 May 2026 20:24:15 +0800, Junxi Qian wrote:
> fuse_iomap_writeback_range() appends one folio pointer and one
> fuse_folio_desc for every dirty range that is merged into the current
> writeback request. The merge decision checks the byte budget against
> fc->max_pages and fc->max_write, but it does not check whether the folio
> and descriptor arrays still have another free slot.
>
> This is not sufficient for fuseblk, where the filesystem block size can
> be smaller than PAGE_SIZE. With writeback cache enabled and max_pages
> negotiated as one, contiguous sub-page dirty ranges can fit within the
> byte budget while spanning more than one folio. The next append can then
> write past the one-slot folios and descs arrays.
>
> [...]
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] fuse: fix writeback array overflow when max_pages is one
https://git.kernel.org/vfs/vfs/c/fde8a3147d3b
prev parent reply other threads:[~2026-05-11 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 12:24 [PATCH] fuse: fix writeback array overflow when max_pages is one Junxi Qian
2026-05-07 15:49 ` Miklos Szeredi
2026-05-11 10:38 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511-trotz-stopfen-bcbd74d26b06@brauner \
--to=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joannelkoong@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=qjx1298677004@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox