From: Christoph Hellwig <hch@lst.de>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: sj1557.seo@samsung.com, yuezhang.mo@sony.com, brauner@kernel.org,
djwong@kernel.org, hch@lst.de, linux-fsdevel@vger.kernel.org,
anmuxixixi@gmail.com, dxdt@dev.snart.me, chizhiling@kylinos.cn,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 9/9] exfat: add support for SEEK_HOLE and SEEK_DATA in llseek
Date: Tue, 12 May 2026 08:40:27 +0200 [thread overview]
Message-ID: <20260512064027.GB31640@lst.de> (raw)
In-Reply-To: <20260507124238.7313-10-linkinjeon@kernel.org>
> } else {
> + /*
> + * valid_size is tracked in byte granularity and
> + * marks the exact boundary between valid data and
> + * holes (or unwritten space).
> + *
> + * When IOMAP_REPORT is set (used by lseek(SEEK_HOLE)
> + * and SEEK_DATA), we return IOMAP_HOLE. This allows
> + * iomap_seek_hole_iter() to directly return the
> + * precise byte position.
> + *
> + * For normal I/O paths (without IOMAP_REPORT) we
> + * return IOMAP_UNWRITTEN so the write path can
> + * distinguish it from a real hole.
> + */
Ahhm this mostly has what I asked for earlier. But maybe also
describe the IOMAP_F_ZERO_TAIL handling a bit above?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-05-12 6:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 12:42 [PATCH v2 0/9] exfat: convert to iomap Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 1/9] exfat: replace unsafe macros with static inline functions Namjae Jeon
2026-05-07 13:41 ` CharSyam
2026-05-07 23:36 ` Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 2/9] exfat: add balloc parameter to exfat_map_cluster() for iomap support Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 3/9] exfat: add exfat_file_open() Namjae Jeon
2026-05-07 13:52 ` CharSyam
2026-05-07 23:37 ` Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 4/9] exfat: add support for multi-cluster allocation Namjae Jeon
2026-05-07 14:09 ` CharSyam
2026-05-08 0:27 ` Namjae Jeon
2026-05-10 13:32 ` Chi Zhiling
2026-05-11 0:20 ` Namjae Jeon
2026-05-11 0:45 ` Chi Zhiling
2026-05-07 12:42 ` [PATCH v2 5/9] iomap: introduce IOMAP_F_ZERO_TAIL flag Namjae Jeon
2026-05-09 9:59 ` Chi Zhiling
2026-05-09 14:30 ` Namjae Jeon
2026-05-11 12:45 ` Christoph Hellwig
2026-05-11 13:46 ` Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 6/9] exfat: add data_start_bytes and exfat_cluster_to_phys() helper Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 7/9] exfat: add iomap buffered I/O support Namjae Jeon
2026-05-12 6:34 ` Christoph Hellwig
2026-05-12 7:40 ` Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 8/9] exfat: add iomap direct " Namjae Jeon
2026-05-12 6:37 ` Christoph Hellwig
2026-05-12 7:47 ` Namjae Jeon
2026-05-07 12:42 ` [PATCH v2 9/9] exfat: add support for SEEK_HOLE and SEEK_DATA in llseek Namjae Jeon
2026-05-12 6:40 ` Christoph Hellwig [this message]
2026-05-12 7:50 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512064027.GB31640@lst.de \
--to=hch@lst.de \
--cc=anmuxixixi@gmail.com \
--cc=brauner@kernel.org \
--cc=chizhiling@kylinos.cn \
--cc=djwong@kernel.org \
--cc=dxdt@dev.snart.me \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox