From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A723D33859A for ; Mon, 18 May 2026 10:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100827; cv=none; b=Ku2dbh/k4I0V6ttzTMJWJ4kPqstQ7TAxJHCLR2hjORAvsimsUTPRScDHaVbVzR47+wz67zVY9X1osLaWBnlTBvA8xeiMZqcbKPfisJb7Bwi+grzDCpSfC+s8KU6dlEFUqXOGAcqWuca0/K/hVmltbLttRKZaXbS/OvoRGsAkcT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779100827; c=relaxed/simple; bh=nvWmJIaONRzVgGZxYOqc+RrJHx05ZpEkKGknRiyvoD8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pvZnS8gVCMwtWoBL35q087U3Q77IEj3B6ch7pLLJzPAuFNJ37A23NMf/Y/NhKwJgi90cB48VVZD2m4pOKd3rhtazuiTDLIBY93FliiOQxciaZEH1NH1yNP5x5OV1JjYh03ZvBRzGP+GnNysu+3HbIok/kxQLw7MWigsHV81ccHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YOYYn5lU; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YOYYn5lU" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4891b0786beso14992095e9.1 for ; Mon, 18 May 2026 03:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779100813; x=1779705613; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KBUJm1g4jrVLHLARnQ410xCyIfZ2+knqUA7xvFczZVo=; b=YOYYn5lUbwDpJJVHgwa+b/uqKmMzzJUm2hIehQT0RfeFic6DPTkEctu4+6yrgoTAaT u9kxlBwiCUk0uHQ4MQ/QBAMPpt5K718IZ1zg5BOo0iQ4OLbx3XAXNVsWFT6PYjxqxiG3 oHvr3OC9nqzpeCxci5FlRGKp37b70XvyPHj0YP2cIbP8cJX6i2a3sWtAjU3noV+2X2PV wkzhPFtUIxCLP4t2y+z/oBQ4ozn1vMXZ6+OkNNIHU/t1RtK8qSsYeCEvIA84yzvQhJL7 MTCcnZhiu8pCfSAOkym3yaNcHT8UovdrqFjblxy1DWYmyiaOdzDrXeutHhDa+t8th2oz CsUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779100813; x=1779705613; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KBUJm1g4jrVLHLARnQ410xCyIfZ2+knqUA7xvFczZVo=; b=UG/2dzyTmrOk0a/b0GXYnLkLFM0nJZGP9X2EdY2Xjxw4oRK6GKJNqK8zlrvxTYzKWK gOrRALD/D/4yBZMz+qFtXwhkRfzsoFoQtHqufoYTfkkM9BaUDBD+jkulsktIKJOHdYh4 6bwIPuxoVrKCxHop39soYeh3Io1P6lmiHSbBowVYhN0+L4MG6Beqz6conq0syQYzBqJZ U0r+tpNKGfpPZcBkA7GEZ1tt0UN6IzwkXRQ39QoAU9MLB0ovFa9N6TqnEJelnXjop6dM zJQsLuNC0QwbZgYKQs15O91uOpBSITr+bLynD7PdHIlljZj+9PizDbAfvvqbnSpim5Ss Xzgg== X-Forwarded-Encrypted: i=1; AFNElJ9+ziUs3QqYeZnZyj1u28M/Ci2HXdritzTRN7wEHOCysja3i60JaQ5LXKeYbsfY+GAMbAklyzWZ9/HnmuDq@vger.kernel.org X-Gm-Message-State: AOJu0Ywnp0yhN5QO4be5aLiSQNKwxbkMlvjS+IlFax2fKoT7VrTZ3eGB 2pR0p7J/Hf2OpEf03raZMBdrnZQh334ZQtBCGpRrXXWakthGqB1e8++Z X-Gm-Gg: Acq92OFAf+4eBE+b8WzH2AWj6a3JUR+XgLW9kdUCK3KQT312FK4MHOrVJH9Eb/8K4Oa jkB6jkqQtcYUS0MIx8bT1CbTQp+HIguTHcdCsDoq+iW9g2ig56qjMkgMFiLWVE5tLnkGSQEmPJ4 TvfsN9Eyd63F+skJe/e2RH5R89F/fQB66/IaBRrWzqpQ0s52Ykc5YSry0Dv77l0O70lsxQVsA5X hwXHDwSunQYUMQqO8JmWslNU52OHJWgtKEDPLU4qEX2h8j0B0/CoFVl8kCifNbQwyzMqAztZrK8 h0kjZAuf2J6Klma+l5vN+qTVJu7ZI07fmEKqogj7Ae8oMkOg8oUSNEgEfyGjbCdTXkodfnDErE1 Iii506lYoBzUOhbrwcQ7pR3l1PrIFs/BJo7ldWnbnoP7QiO1lvjxFC0Bj4drPGcR69OXiTy0oG6 QFNKX4uTNPZ4D95TJgBJDNjq0u1Ruh94p0WAPICpGNsbdBtKBskNeYFdjm4xGiJdCafvd/kpHa6 bVpoO37/cXL9w== X-Received: by 2002:a05:600c:4fc9:b0:489:1c1f:35df with SMTP id 5b1f17b1804b1-48fe60e58ecmr202920365e9.10.1779100812550; Mon, 18 May 2026 03:40:12 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c90b27sm255713955e9.8.2026.05.18.03.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 03:40:12 -0700 (PDT) Date: Mon, 18 May 2026 11:40:10 +0100 From: David Laight To: Pavel Begunkov Cc: Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , Christian =?UTF-8?B?S8O2bmln?= , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe Subject: Re: [PATCH v3 02/10] iov_iter: add iterator type for dmabuf maps Message-ID: <20260518114010.6e1f7391@pumpkin> In-Reply-To: <4b2f74e9-3225-47f6-85fe-911720030e35@gmail.com> References: <20a233d2f35274817aa643cc0fe113707eb47e72.1777475843.git.asml.silence@gmail.com> <20260513110557.705bdeed@pumpkin> <20260513142909.03ae6c2b@pumpkin> <4b2f74e9-3225-47f6-85fe-911720030e35@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 May 2026 10:24:35 +0100 Pavel Begunkov wrote: > On 5/13/26 14:29, David Laight wrote: > > On Wed, 13 May 2026 11:05:57 +0100 > > David Laight wrote: > > > > ... > >>> @@ -575,7 +575,8 @@ void iov_iter_advance(struct iov_iter *i, size_t size) > >>> { > >>> if (unlikely(i->count < size)) > >>> size = i->count; > >>> - if (likely(iter_is_ubuf(i)) || unlikely(iov_iter_is_xarray(i))) { > >>> + if (likely(iter_is_ubuf(i)) || unlikely(iov_iter_is_xarray(i)) || > >>> + unlikely(iov_iter_is_dmabuf_map(i))) { > >> > >> > >> Doesn't the extra check add more code to all the non-ubuf cases? ... > >> or writing an iter_is_one_of(i, ITER_xxx, ITER_yyy) define that uses > >> '(1 << i->iter_type) & ((1 << ITER_xxx) | ...)' > > > > This seems to DTRT: > > > > #define _ITER_IS_ONE_OF(iter, t1, t2, t3, t4, t5, t6, t7, t8, ...) \ > > ((1u << (iter)->iter_type) & ((1u << ITER_##t1) | (1u << ITER_##t2) | \ > > (1u << ITER_##t3) | (1u << ITER_##t4) | (1u << ITER_##t5) | \ > > (1u << ITER_##t6) | (1u << ITER_##t7) | (1u << ITER_##t8))) > > #define ITER_IS_ONE_OF(iter, t, ...) \ > > _ITER_IS_ONE_OF(iter, t, ## __VA_ARGS__, t, t, t, t, t, t, t) > > We definitely don't want that, using them directly would've been > much cleaner. > > if (get_type_mask(i) & (TYPE1 | TYPE2)) ... You need to shift all the TYPEn as well. The above condition would become: if (likely(ITER_IS_ONE_OF(i, UBUF, XARRAY, DMABUF_MAP))) { which reads reasonable well. Without the token pasting it becomes: if (likely(ITER_IS_ONE_OF(i, ITER_UBUF, ITER_XARRAY, ITER_DMABUF_MAP))) { and the line starts getting long. Although that version probably needs a check that the mask is constant. -- David >