From: Dev Jain <dev.jain@arm.com>
To: akpm@linux-foundation.org, liam@infradead.org, ljs@kernel.org,
jgg@ziepe.ca, leon@kernel.org, david@kernel.org,
shuah@kernel.org
Cc: Dev Jain <dev.jain@arm.com>,
vbabka@kernel.org, jannh@google.com, pfalcato@suse.de,
balbirs@nvidia.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
linux-kselftest@vger.kernel.org, usama.arif@linux.dev,
ryan.roberts@arm.com, anshuman.khandual@arm.com
Subject: [PATCH v2 2/2] selftests/mm/hmm-tests: test pagemap reads of PMD device-private entries
Date: Sat, 30 May 2026 08:54:12 +0000 [thread overview]
Message-ID: <20260530085413.1270139-3-dev.jain@arm.com> (raw)
In-Reply-To: <20260530085413.1270139-1-dev.jain@arm.com>
To cover pagemap paths scanning PMD entries, add assertions to check
whether a device-private PMD entry has the correct pagemap information -
the PM_SWAP bit must be on in the pagemap entry. Before that, we must
assert through HMM_DMIRROR_SNAPSHOT snapshot that the leaf entry is
at PMD level and not PTE level.
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
tools/testing/selftests/mm/hmm-tests.c | 29 ++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c
index e1c8a679a4cf3..d09d4a9081de1 100644
--- a/tools/testing/selftests/mm/hmm-tests.c
+++ b/tools/testing/selftests/mm/hmm-tests.c
@@ -2276,8 +2276,11 @@ TEST_F(hmm, migrate_anon_huge_fault)
unsigned long npages;
unsigned long size;
unsigned long i;
+ unsigned char *m;
+ uint64_t entry;
void *old_ptr;
void *map;
+ int pagemap_fd;
int *ptr;
int ret;
@@ -2318,6 +2321,32 @@ TEST_F(hmm, migrate_anon_huge_fault)
for (i = 0, ptr = buffer->mirror; i < size / sizeof(*ptr); ++i)
ASSERT_EQ(ptr[i], i);
+ if (!hmm_is_coherent_type(variant->device_number)) {
+ ret = hmm_dmirror_cmd(self->fd, HMM_DMIRROR_SNAPSHOT,
+ buffer, npages);
+ ASSERT_EQ(ret, 0);
+ ASSERT_EQ(buffer->cpages, npages);
+
+ m = buffer->mirror;
+ for (i = 0; i < npages; ++i)
+ ASSERT_EQ(m[i], HMM_DMIRROR_PROT_DEV_PRIVATE_LOCAL |
+ HMM_DMIRROR_PROT_WRITE |
+ HMM_DMIRROR_PROT_PMD);
+
+ pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
+ ASSERT_GE(pagemap_fd, 0);
+
+ for (i = 0; i < npages; ++i) {
+ entry = pagemap_get_entry(pagemap_fd,
+ (char *)buffer->ptr + i * self->page_size);
+
+ ASSERT_NE(entry & PM_SWAP, 0);
+ ASSERT_EQ(entry & PM_PRESENT, 0);
+ }
+
+ close(pagemap_fd);
+ }
+
/* Fault pages back to system memory and check them. */
for (i = 0, ptr = buffer->ptr; i < size / sizeof(*ptr); ++i)
ASSERT_EQ(ptr[i], i);
--
2.43.0
next prev parent reply other threads:[~2026-05-30 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 8:54 [PATCH v2 0/2] mm/hmm: A fix and a selftest Dev Jain
2026-05-30 8:54 ` [PATCH v2 1/2] fs/proc/task_mmu: do not warn on seeing non-migration pmd entry Dev Jain
2026-05-31 23:39 ` Balbir Singh
2026-06-01 8:36 ` Lorenzo Stoakes
2026-05-30 8:54 ` Dev Jain [this message]
2026-06-01 0:09 ` [PATCH v2 2/2] selftests/mm/hmm-tests: test pagemap reads of PMD device-private entries Balbir Singh
2026-06-01 5:10 ` Dev Jain
2026-06-01 8:35 ` Lorenzo Stoakes
2026-06-01 9:14 ` Dev Jain
2026-05-31 19:24 ` [PATCH v2 0/2] mm/hmm: A fix and a selftest Andrew Morton
2026-05-31 19:49 ` David Hildenbrand (Arm)
2026-06-01 5:11 ` Dev Jain
2026-06-01 8:33 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260530085413.1270139-3-dev.jain@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=balbirs@nvidia.com \
--cc=david@kernel.org \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox