Linux filesystem development
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	pr-tracker-bot@kernel.org, Breno Leitao <leitao@debian.org>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] configfs cleanups and fixes (with tag on correct branch now)
Date: Mon, 15 Jun 2026 20:25:40 +0100	[thread overview]
Message-ID: <20260615192540.GX2636677@ZenIV> (raw)
In-Reply-To: <87qzm8f894.fsf@kernel.org>

On Mon, Jun 15, 2026 at 11:44:23AM +0200, Andreas Hindborg wrote:

> Amazing!
> 
> I was sort of dreading having to go through all of this to make heads
> and tails of it, but I put it down as a task that I would have to do
> within the next few months.
> 
> I guess I did not have to worry about that. I am happy that I did not
> have to handle that, but I am also stumped that I did not have to handle
> that.

FWIW, configfs-related stuff I've got for the next cycle:
	* use ..._recursive_removal() for all removals
	* build new subtrees isolated, then move in place
	* kill the lockdep magic, since deep chains of locked directories
are no longer used
	* kill the "is it ready" thing
Those are already more or less linearized into #more.configfs - not the
final form, and there might be some reordering, but basically there.

In local branches, should go into the mix by -rc1:
	* saner waiting for mkdir in progress by rmdir et.al. - doing
that on inode lock for parent directory is not a good way to do it.
	* a bunch of cleanups.

Stuff yet to be figured out:
	configfs_depend_item{,_unlocked}() work; the rules for clients are
less than obvious and in the current form it's seriously racy.	The few
existing users (all 6 of them) _might_ be OK, but I've no idea where to
start with safety proofs on those.  That might end up slipping further -
I hadn't tried to contact the folks who might remember the underlying
history yet.  In particular, configfs_depend_item_unlocked() had been
posted in early 2015 and merged in end of the same year; unfortunately,
it had been changed a _lot_ between the last posting and actual merge
and I hadn't been able to find any traces of discussion anywhere.  Maybe
Andrzej Pietrasiewicz has some memories of that thing - other likely
participants appear to have moved on ;-/

  reply	other threads:[~2026-06-15 19:25 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  7:06 [RFC PATCH 00/14] configfs cleanups and fixes Al Viro
2026-05-19  7:06 ` [RFC PATCH 01/14] configfs_lookup(): don't leave ->s_dentry dangling on failure Al Viro
2026-05-19  9:57   ` Jan Kara
2026-05-21 16:38   ` Breno Leitao
2026-05-19  7:06 ` [RFC PATCH 02/14] configfs_mkdir(): use take_dentry_name_snapshot() Al Viro
2026-05-19  9:59   ` Jan Kara
2026-05-21 16:54   ` Breno Leitao
2026-05-19  7:06 ` [RFC PATCH 03/14] configfs_detach_prep(): pass configfs_dirent instead of dentry Al Viro
2026-05-19 10:12   ` Jan Kara
2026-05-21 17:03   ` Breno Leitao
2026-05-19  7:06 ` [RFC PATCH 04/14] configfs_depend_prep(): " Al Viro
2026-05-19 10:18   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 05/14] configfs_do_depend_item(): " Al Viro
2026-05-19 10:25   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 06/14] configfs_detach_rollback(): " Al Viro
2026-05-19 10:26   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 07/14] populate_group(): move cleanup on failure to the sole caller Al Viro
2026-05-19 10:29   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 08/14] populate_attrs(): move cleanup " Al Viro
2026-05-19 10:31   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 09/14] configfs_remove_dir(), detach_attrs(): switch to passing dentry Al Viro
2026-05-19 10:42   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 10/14] switch configfs_detach_{group,item}() " Al Viro
2026-05-19 12:10   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 11/14] configfs: dentry refcount needs to be pinned only once Al Viro
2026-05-19 13:21   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 12/14] configfs: mark pinned dentries persistent Al Viro
2026-05-19 13:03   ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 13/14] kill configfs_drop_dentry() Al Viro
2026-05-19 13:12   ` Jan Kara
2026-05-19 14:44     ` Linus Torvalds
2026-05-19 15:37     ` Al Viro
2026-05-19 21:06       ` Jan Kara
2026-05-19  7:06 ` [RFC PATCH 14/14] configfs_create(): lift parent timestamp updates into callers Al Viro
2026-05-19 13:23   ` Jan Kara
2026-06-03  7:47 ` [PATCH v2 00/18] configfs cleanups and fixes Al Viro
2026-06-03  7:47   ` [PATCH v2 01/18] configfs_lookup(): don't leave ->s_dentry dangling on failure Al Viro
2026-06-03  7:47   ` [PATCH v2 1/3] get rid of impossible checks in detach_attrs()/configfs_detach_item() Al Viro
2026-06-03  7:53     ` Al Viro
2026-06-03  8:09       ` Christian Brauner
2026-06-03  8:28         ` Al Viro
2026-06-03  7:47   ` [PATCH v2 2/3] configfs_detach_item(): victim is never negative Al Viro
2026-06-03  7:47   ` [PATCH v2 02/18] configfs: fix lockless traversals of ->s_children Al Viro
2026-06-08 12:40     ` Jan Kara
2026-06-03  7:47   ` [PATCH v2 3/3] configfs: expand the call of simple_rmdir() Al Viro
2026-06-03  7:48   ` [PATCH v2 03/18] configfs_mkdir(): use take_dentry_name_snapshot() Al Viro
2026-06-03  7:48   ` [PATCH v2 04/18] configfs_detach_prep(): pass configfs_dirent instead of dentry Al Viro
2026-06-03  7:48   ` [PATCH v2 05/18] configfs_depend_prep(): " Al Viro
2026-06-03  7:48   ` [PATCH v2 06/18] configfs_do_depend_item(): " Al Viro
2026-06-03  7:48   ` [PATCH v2 07/18] configfs_detach_rollback(): " Al Viro
2026-06-03  7:48   ` [PATCH v2 08/18] populate_group(): move cleanup on failure to the sole caller Al Viro
2026-06-03  7:48   ` [PATCH v2 09/18] populate_attrs(): move cleanup " Al Viro
2026-06-03  7:48   ` [PATCH v2 10/18] configfs_remove_dir(), detach_attrs(): switch to passing dentry Al Viro
2026-06-03  7:48   ` [PATCH v2 11/18] switch configfs_detach_{group,item}() " Al Viro
2026-06-03  7:48   ` [PATCH v2 12/18] configfs: dentry refcount needs to be pinned only once Al Viro
2026-06-03  7:48   ` [PATCH v2 13/18] configfs: mark pinned dentries persistent Al Viro
2026-06-03  7:48   ` [PATCH v2 14/18] kill configfs_drop_dentry() Al Viro
2026-06-08 12:46     ` Jan Kara
2026-06-03  7:48   ` [PATCH v2 15/18] configfs_create(): lift parent timestamp updates into callers Al Viro
2026-06-03  7:48   ` [PATCH v2 16/18] configs_attach_item(): drop unused parent_item argument Al Viro
2026-06-08 12:42     ` Jan Kara
2026-06-03  7:48   ` [PATCH v2 17/18] configfs_attach_group(): drop the " Al Viro
2026-06-08 12:43     ` Jan Kara
2026-06-03  7:48   ` [PATCH v2 18/18] create_default_group(): pass parent's dentry instead of config_group Al Viro
2026-06-08 12:43     ` Jan Kara
2026-06-14 22:36   ` [git pull] configfs cleanups and fixes Al Viro
2026-06-14 22:39     ` Al Viro
2026-06-14 22:44       ` [git pull] configfs cleanups and fixes (with tag on correct branch now) Al Viro
2026-06-15  3:45         ` pr-tracker-bot
2026-06-15  9:44           ` Andreas Hindborg
2026-06-15 19:25             ` Al Viro [this message]
2026-06-14 22:52       ` [git pull] configfs cleanups and fixes Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260615192540.GX2636677@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=a.hindborg@kernel.org \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=leitao@debian.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=pr-tracker-bot@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox