From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 17/20] afs: Fix vllist leak
Date: Thu, 18 Jun 2026 16:51:36 +0100 [thread overview]
Message-ID: <20260618155141.2513212-18-dhowells@redhat.com> (raw)
In-Reply-To: <20260618155141.2513212-1-dhowells@redhat.com>
Fix a leak of the new vllist in afs_update_cell() in the event that it is an
empty list (nr_servers == 0), in which case the old list isn't displaced
unless the old list is also empty.
Fixes: d5c32c89b208 ("afs: Fix cell DNS lookup")
Closes: https://sashiko.dev/#/patchset/20260609081738.770127-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
---
fs/afs/cell.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/afs/cell.c b/fs/afs/cell.c
index e0fab1609f27..fbb8a43aa7cd 100644
--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -547,6 +547,8 @@ static int afs_update_cell(struct afs_cell *cell)
rcu_assign_pointer(cell->vl_servers, vllist);
cell->dns_source = vllist->source;
old = p;
+ } else {
+ old = vllist;
}
write_unlock(&cell->vl_servers_lock);
afs_put_vlserverlist(cell->net, old);
next prev parent reply other threads:[~2026-06-18 15:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 15:51 [PATCH v3 00/20] afs: Miscellaneous fixes David Howells
2026-06-18 15:51 ` [PATCH v3 01/20] afs: handle CB.InitCallBackState3 requests without a server record David Howells
2026-06-18 15:51 ` [PATCH v3 02/20] afs: Fix error code in afs_extract_vl_addrs() David Howells
2026-06-18 15:51 ` [PATCH v3 03/20] afs: fix NULL pointer dereference in afs_get_tree() David Howells
2026-06-18 15:51 ` [PATCH v3 04/20] afs: Fix double netfs initialisation in afs_root_iget() David Howells
2026-06-18 15:51 ` [PATCH v3 05/20] afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints David Howells
2026-06-18 15:51 ` [PATCH v3 06/20] afs: Fix directory inode initialisation order David Howells
2026-06-18 15:51 ` [PATCH v3 07/20] afs: use kvfree() to free memory allocated by kvcalloc() David Howells
2026-06-18 15:51 ` [PATCH v3 08/20] afs: Remove erroneous seq |= 1 in volume lookup loop David Howells
2026-06-18 15:51 ` [PATCH v3 09/20] afs: check for duplicate servers in VL server list David Howells
2026-06-18 15:51 ` [PATCH v3 10/20] afs: Fix bulk lookup malfunction due to change in dir_emit() API David Howells
2026-06-18 15:51 ` [PATCH v3 11/20] afs: Fix misplaced inc of net->cells_outstanding David Howells
2026-06-22 20:29 ` XIAO WU
2026-06-18 15:51 ` [PATCH v3 12/20] afs: Fix reinitialisation of the inode, in particular ->lock_work David Howells
2026-06-18 15:51 ` [PATCH v3 13/20] afs: Fix callback service message parsers to pass through -EAGAIN David Howells
2026-06-18 15:51 ` [PATCH v3 14/20] afs: Use scoped_seqlock_read() rather than manually doing seqlock stuff David Howells
2026-06-18 15:51 ` [PATCH v3 15/20] afs: Fix missing NULL pointer check in afs_break_some_callbacks() David Howells
2026-06-18 15:51 ` [PATCH v3 16/20] afs: Fix leak of ungot volume David Howells
2026-06-18 15:51 ` David Howells [this message]
2026-06-18 15:51 ` [PATCH v3 18/20] afs: Fix lack of locking around modifications of net->cells_dyn_ino David Howells
2026-06-22 20:29 ` XIAO WU
2026-06-22 20:31 ` XIAO WU
2026-06-18 15:51 ` [PATCH v3 19/20] afs: Fix the volume AFS_VOLUME_RM_TREE is set on David Howells
2026-06-18 15:51 ` [PATCH v3 20/20] afs: Fix unchecked-length string display in debug statement David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618155141.2513212-18-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=christian@brauner.io \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox