Linux filesystem development
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: David Howells <dhowells@redhat.com>,
	Marc Dionne <marc.dionne@auristor.com>,
	linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Deepakkumar Karn <dkarn@redhat.com>
Subject: [PATCH v4 16/21] afs: Fix leak of ungot volume
Date: Mon, 22 Jun 2026 10:08:50 +0100	[thread overview]
Message-ID: <20260622090856.2746629-17-dhowells@redhat.com> (raw)
In-Reply-To: <20260622090856.2746629-1-dhowells@redhat.com>

Fix afs_lookup_volume_rcu() so that it doesn't leak a dying volume if
afs_try_get_volume() fails.

Fixes: 32222f09782f ("afs: Apply server breaks to mmap'd files in the call processor")
Closes: https://sashiko.dev/#/patchset/20260609081738.770127-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Deepakkumar Karn <dkarn@redhat.com>
cc: linux-afs@lists.infradead.org
---
 fs/afs/callback.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 74853e0d0435..61354003c006 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -134,6 +134,7 @@ static struct afs_volume *afs_lookup_volume_rcu(struct afs_cell *cell,
 
 		if (volume && afs_try_get_volume(volume, afs_volume_trace_get_callback))
 			break;
+		volume = NULL;
 	}
 
 	return volume;


  parent reply	other threads:[~2026-06-22  9:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22  9:08 [PATCH v4 00/21] afs: Miscellaneous fixes David Howells
2026-06-22  9:08 ` [PATCH v4 01/21] afs: handle CB.InitCallBackState3 requests without a server record David Howells
2026-06-22  9:08 ` [PATCH v4 02/21] afs: Fix error code in afs_extract_vl_addrs() David Howells
2026-06-22  9:08 ` [PATCH v4 03/21] afs: fix NULL pointer dereference in afs_get_tree() David Howells
2026-06-22  9:08 ` [PATCH v4 04/21] afs: Fix double netfs initialisation in afs_root_iget() David Howells
2026-06-22  9:08 ` [PATCH v4 05/21] afs: Remove setting of AS_RELEASE_ALWAYS for symlinks and mountpoints David Howells
2026-06-22  9:08 ` [PATCH v4 06/21] afs: Fix directory inode initialisation order David Howells
2026-06-22  9:08 ` [PATCH v4 07/21] afs: use kvfree() to free memory allocated by kvcalloc() David Howells
2026-06-22  9:08 ` [PATCH v4 08/21] afs: Remove erroneous seq |= 1 in volume lookup loop David Howells
2026-06-22  9:08 ` [PATCH v4 09/21] afs: check for duplicate servers in VL server list David Howells
2026-06-22  9:08 ` [PATCH v4 10/21] afs: Fix bulk lookup malfunction due to change in dir_emit() API David Howells
2026-06-22  9:08 ` [PATCH v4 11/21] afs: Fix misplaced inc of net->cells_outstanding David Howells
2026-06-22  9:08 ` [PATCH v4 12/21] afs: Fix reinitialisation of the inode, in particular ->lock_work David Howells
2026-06-22  9:08 ` [PATCH v4 13/21] afs: Fix callback service message parsers to pass through -EAGAIN David Howells
2026-06-22  9:08 ` [PATCH v4 14/21] afs: Use scoped_seqlock_read() rather than manually doing seqlock stuff David Howells
2026-06-22  9:08 ` [PATCH v4 15/21] afs: Fix missing NULL pointer check in afs_break_some_callbacks() David Howells
2026-06-22  9:08 ` David Howells [this message]
2026-06-22  9:08 ` [PATCH v4 17/21] afs: Fix vllist leak David Howells
2026-06-22  9:08 ` [PATCH v4 18/21] afs: Fix lack of locking around modifications of net->cells_dyn_ino David Howells
2026-06-22  9:08 ` [PATCH v4 19/21] afs: Fix premature cell exposure through /afs David Howells
2026-06-22  9:29   ` David Howells
2026-06-22  9:08 ` [PATCH v4 20/21] afs: Fix the volume AFS_VOLUME_RM_TREE is set on David Howells
2026-06-22  9:08 ` [PATCH v4 21/21] afs: Fix unchecked-length string display in debug statement David Howells
2026-06-22 14:37 ` [PATCH v4 00/21] afs: Miscellaneous fixes Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260622090856.2746629-17-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=christian@brauner.io \
    --cc=dkarn@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox