From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E19D280CE5 for ; Sat, 11 Jul 2026 15:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782431; cv=none; b=fgUL8UQvxUoaw9DvBrUfboBEov7HdLcUWU5wib07FM9pG9Qmsu0Qn2uVbL0hAv0v/c3h4pLVZrtrHCPP7A4sN5/PyON4Leot85X2asTwe3rQIuVLH/q+RI/5zQNsRRZIicWQAsn+4Jmi0Gdqd+KL7Aj6mLazUvmuO2kk6gnp2mA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782431; c=relaxed/simple; bh=5aUkxlSIulkhERNeZp4fHGXyOVMGdheq/O6gyd5lrIA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HEAI+UkoClNatFPTJcMVxKttzaRAR6ZnC29GSskGnT1JYNmUamnMmFmigLLcHSgR+S79Mej3NVpWmHMKZ6rPqbGwYUsxVEnq0LGS3vafIjWXHZsLJlLPPpGjssFx/eEljjBNZEhyiauE7ZPLN0iy3JlwCwIf6osHulst/2eu1JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PtDJR1tI; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PtDJR1tI" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-92efc443c61so20850985a.2 for ; Sat, 11 Jul 2026 08:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783782429; x=1784387229; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=lTWLgXlcQl8Cccs9msbh22ddO/TiG4mAqMFaTuD2LHY=; b=PtDJR1tIlWmKkiXkJgiHUpjK51g+vMdLJ4Oy59n87baZyHxXwPjZ6bS9n9AWnN6ZJq /9e//4H8NsDdig5cwLLJpX8qc6CsXm1VkfGck6l6BbjD6pZVBafceT06FuP3T6wHkW26 Ts8UDBTyx+uV26uD/md4bmlnHcrT7FLR0kKCEFvH3aKZzuGApVqqGledE4A2bzqgd+jI v2xBiIxh8nBVsT0u1AwCB6FTB9ispW2DbLlBBwbewIRe9dihGB3DSlrCgKzxihHZxf3q z9FvXSTvOSsMcYdWJG8B0X+SLvz8XB9jXNzYfMV73OvbFURzbCqVbM20kFc7h7a9bIUQ uGzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782429; x=1784387229; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lTWLgXlcQl8Cccs9msbh22ddO/TiG4mAqMFaTuD2LHY=; b=FLygwUahs9oCpoME+WDsWNjZcjUJada8TUQJwBlHR4oHAJEIplH6/xgvOzjVoQHta3 358YJ9SlCMbabDHUU7XGJY4+VZ+bXixXxl8x+rlRtoyuT/ECqtXGnlEBQ+Krg8sTriDN H8oSWhhnAze3czswo2EY9XQl7AblbnTK5mlTyyUPOdrlfDAj7MIIfHHey4odRMwmFH/t 8genhRBzeFqhBYp0WqnK0CylDBB5K0ClOjA6W97f2zwiaY7sBMUoAZXDxhdxKizMvODb zukPS/1PLQu4HOeqoa61A1f4fxzyg8TVIBjXeZbvIY9HgKG6Dj3QxMtPbZo6oO9g/+M/ cOdg== X-Forwarded-Encrypted: i=1; AHgh+RpN+1PkPfjMNqewsNtCJtrxWZy8Dw8hc1uMjrEoZqoOU0LQu+GgBTEsSDclWS/tndPDz4BVcii4XuC0xTvK@vger.kernel.org X-Gm-Message-State: AOJu0YzUQF8gvFPio7+ISyoiQprsDQZTQgtQIe5FkHgv4hCziZF+W7hi aN2WtEFHbNHEaGUvTdV19N+N3U42Ous3QGjENkFRCUpVNVIZycNUKw71 X-Gm-Gg: AfdE7cl7cc9XhNf6pZqUmIAy+TxWSCjy3eR4T3yhP+4ifPgWm7DRBRIvxK4DxfPeibY V8YBV0LDY+9HGUn2f5e230KIqeWKtbAWIgSDoF12gpLBIzGwKelqhcFtDZqqRtL215sPbcqvfAD OilRCUPx0Yn1WE5v5ZXqQqcUGeZRUukHUQAPPcL9WIWpaOcGHd+Cl2uLxczqPpeB+KqlkXHPkHY bvQnwH9p6ALTWuzycodyRPrHszuaCN5Q+gVkTE1FDyW8RmGjCnei0aHB7J7NjTPTY3GP7Q9T2uJ PmYGmZL7XNeBFBTbuFRL/Vf/DjlcaIxPljZwG41zlHPf0uK2psEEg5lnIMA2AufU2qb9fX9wE8x 8Lx8dpak3RF9czLC3SzYqBLAGY8cH4TLnqvVv5f7XcvqRBH/l9KiYT8kz8Wl149P1MigWZwm476 aCmq+paAECKSawXjfHXS+YXzTvZLX5KwVqy9GtSVxXc7sUuHSLTZrzz2ndISoUKumGQ5l42c6YO 7E8lq/aRA== X-Received: by 2002:a05:620a:394b:b0:92e:e252:bb43 with SMTP id af79cd13be357-92ef2cd093amr367391985a.77.1783782428765; Sat, 11 Jul 2026 08:07:08 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5b8b3f2sm471818485a.13.2026.07.11.08.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 08:07:08 -0700 (PDT) From: Michael Bommarito To: Ilya Dryomov , Xiubo Li , Alex Markuze Cc: Viacheslav Dubeyko , ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] ceph: bound copied dentry name length in NFS export get_name Date: Sat, 11 Jul 2026 11:07:05 -0400 Message-ID: <20260711150706.2915970-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ceph_get_name() copies the MDS-supplied name into the caller's NAME_MAX-sized buffer with memcpy(name, rinfo->dname, rinfo->dname_len) and then writes name[rinfo->dname_len] = 0, without checking dname_len against NAME_MAX. A malicious or buggy MDS that returns a LOOKUPNAME reply with dname_len > NAME_MAX overflows the buffer. __get_snap_name() copies rde->name / rde->name_len the same unchecked way. Impact: a malicious or compromised Ceph MDS overflows the NAME_MAX name buffer in a client's NFS-export get_name path, a slab out-of-bounds write reported by KASAN. Reachable when a CephFS mount is re-exported over NFS. Add ceph_export_copy_name(), which rejects lengths above NAME_MAX with -ENAMETOOLONG before the copy, and use it in both ceph_get_name() and __get_snap_name(). Fixes: 19913b4eac4a ("ceph: add get_name() NFS export callback") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Michael Bommarito --- fs/ceph/export.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/fs/ceph/export.c b/fs/ceph/export.c index b2f2af1046791..debb9634b9e3d 100644 --- a/fs/ceph/export.c +++ b/fs/ceph/export.c @@ -442,6 +442,16 @@ static struct dentry *ceph_fh_to_parent(struct super_block *sb, return dentry; } +static int ceph_export_copy_name(char *name, const char *src, u32 len) +{ + if (len > NAME_MAX) + return -ENAMETOOLONG; + + memcpy(name, src, len); + name[len] = '\0'; + return 0; +} + static int __get_snap_name(struct dentry *parent, char *name, struct dentry *child) { @@ -513,9 +523,8 @@ static int __get_snap_name(struct dentry *parent, char *name, BUG_ON(!rde->inode.in); if (ceph_snap(inode) == le64_to_cpu(rde->inode.in->snapid)) { - memcpy(name, rde->name, rde->name_len); - name[rde->name_len] = '\0'; - err = 0; + err = ceph_export_copy_name(name, rde->name, + rde->name_len); goto out; } } @@ -580,8 +589,8 @@ static int ceph_get_name(struct dentry *parent, char *name, rinfo = &req->r_reply_info; if (!IS_ENCRYPTED(dir)) { - memcpy(name, rinfo->dname, rinfo->dname_len); - name[rinfo->dname_len] = 0; + err = ceph_export_copy_name(name, rinfo->dname, + rinfo->dname_len); } else { struct fscrypt_str oname = FSTR_INIT(NULL, 0); struct ceph_fname fname = { .dir = dir, @@ -595,10 +604,9 @@ static int ceph_get_name(struct dentry *parent, char *name, goto out; err = ceph_fname_to_usr(&fname, NULL, &oname, NULL); - if (!err) { - memcpy(name, oname.name, oname.len); - name[oname.len] = 0; - } + if (!err) + err = ceph_export_copy_name(name, oname.name, + oname.len); ceph_fname_free_buffer(dir, &oname); } out: -- 2.53.0