From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout05.his.huawei.com (canpmsgout05.his.huawei.com [113.46.200.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4D68395AE9 for ; Mon, 20 Jul 2026 03:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.220 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784519731; cv=none; b=iH5c1jFGnMzsCVp80REeoprqXXRNf+B7Sma2qfOS8+F879jSAAtFPY9rK60ubER8KaQ4spldL/oT3eo6cfeHn0zHGWeyhkmdiPPJjRSWJBmsVtx/h28Iih9DQo7jzYB/Zh2khKUFnad5RWQkX+PSueIXwoQkVVu2IPlge9Ax/CU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784519731; c=relaxed/simple; bh=IzhMRZ6M14QV8gzl9Mf9IN7oQAwNvItP5bIANfqxCyw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NyKGOHee9JvOn/V55oxtf33kb8Vi4B0ZfGASh8v11rmkY/XdaCUAKGMZuwK0vyvKzbdEW5LrfiqktxCt5106Cg5f3N9S5DZr3ldrKoMo7JwAbd5wqPSjg1km61ZvWj94uiWAcXfTWa/MHfhMOgGFvz45EfTd4G0g6uaGnenBCMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=VIThfSyI; arc=none smtp.client-ip=113.46.200.220 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="VIThfSyI" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=am+19/5kAwq2nurOsVBVrTqc8AGbedae4TuQBKH9vBE=; b=VIThfSyIuCRFCFF1v8dCBMlufnInFQsyK07b6P4yTI6Kf3KVmhmgNQwsTP9gDhNCkdgyAteKy 0wBjZ1xlSovsYSIJjCIHvVcfg81veu5xGCnWB/FcZbQwabsUr0VWp3pXn01GolPk7uBD9xHMqyk As8O/JD0WSEGN7VJhcK4h9E= Received: from mail.maildlp.com (unknown [172.19.162.223]) by canpmsgout05.his.huawei.com (SkyGuard) with ESMTPS id 4h3RHs2r44z12LDF; Mon, 20 Jul 2026 11:45:45 +0800 (CST) Received: from kwepemr500001.china.huawei.com (unknown [7.202.194.229]) by mail.maildlp.com (Postfix) with ESMTPS id 7A08940575; Mon, 20 Jul 2026 11:55:20 +0800 (CST) Received: from huawei.com (10.50.85.135) by kwepemr500001.china.huawei.com (7.202.194.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 20 Jul 2026 11:55:19 +0800 From: Jinjiang Tu To: , , , , , , , , , , CC: , , Subject: [PATCH v2 1/3] fs: stable_page_flags(): use BIT_ULL() for KPF flags Date: Mon, 20 Jul 2026 11:30:19 +0800 Message-ID: <20260720033021.4091944-2-tujinjiang@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720033021.4091944-1-tujinjiang@huawei.com> References: <20260720033021.4091944-1-tujinjiang@huawei.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: kwepems200001.china.huawei.com (7.221.188.67) To kwepemr500001.china.huawei.com (7.202.194.229) The stable_page_flags() function currently sets page flag bits using "1 << KPF_xxx" for various KPF_* definitions. KPF_* may be larger than 32, which will trigger -Wshift-count-overflow warning. All KPF_* values currently used in "1 << KPF_xxx" are smaller than 33, so no warning is triggered with current code. Replace all occurrences of "1 << KPF_*" with the BIT_ULL() macro to ensure all shifts are performed on a 64-bit unsigned type. This makes the code robust, and safe for future extension. No functional change is intended. Acked-by: David Hildenbrand (Arm) Acked-by: Zi Yan Signed-off-by: Jinjiang Tu --- fs/proc/page.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/fs/proc/page.c b/fs/proc/page.c index 7d9387143435..ee39b321f1c6 100644 --- a/fs/proc/page.c +++ b/fs/proc/page.c @@ -157,7 +157,7 @@ u64 stable_page_flags(const struct page *page) * it differentiates a memory hole from a page with no flags */ if (!page) - return 1 << KPF_NOPAGE; + return BIT_ULL(KPF_NOPAGE); snapshot_page(&ps, page); folio = &ps.folio_snapshot; @@ -170,11 +170,11 @@ u64 stable_page_flags(const struct page *page) * pseudo flags for the well known (anonymous) memory mapped pages */ if (folio_mapped(folio)) - u |= 1 << KPF_MMAP; + u |= BIT_ULL(KPF_MMAP); if (is_anon) { - u |= 1 << KPF_ANON; + u |= BIT_ULL(KPF_ANON); if ((mapping & FOLIO_MAPPING_FLAGS) == FOLIO_MAPPING_KSM) - u |= 1 << KPF_KSM; + u |= BIT_ULL(KPF_KSM); } /* @@ -184,35 +184,35 @@ u64 stable_page_flags(const struct page *page) if (ps.idx == 0) u |= kpf_copy_bit(k, KPF_COMPOUND_HEAD, PG_head); else - u |= 1 << KPF_COMPOUND_TAIL; + u |= BIT_ULL(KPF_COMPOUND_TAIL); if (folio_test_hugetlb(folio)) - u |= 1 << KPF_HUGE; + u |= BIT_ULL(KPF_HUGE); else if (folio_test_large(folio) && folio_test_large_rmappable(folio)) { /* Note: we indicate any THPs here, not just PMD-sized ones */ - u |= 1 << KPF_THP; + u |= BIT_ULL(KPF_THP); } else if (is_huge_zero_pfn(ps.pfn)) { - u |= 1 << KPF_ZERO_PAGE; - u |= 1 << KPF_THP; + u |= BIT_ULL(KPF_ZERO_PAGE); + u |= BIT_ULL(KPF_THP); } else if (is_zero_pfn(ps.pfn)) { - u |= 1 << KPF_ZERO_PAGE; + u |= BIT_ULL(KPF_ZERO_PAGE); } if (ps.flags & PAGE_SNAPSHOT_PG_BUDDY) - u |= 1 << KPF_BUDDY; + u |= BIT_ULL(KPF_BUDDY); if (folio_test_offline(folio)) - u |= 1 << KPF_OFFLINE; + u |= BIT_ULL(KPF_OFFLINE); if (folio_test_pgtable(folio)) - u |= 1 << KPF_PGTABLE; + u |= BIT_ULL(KPF_PGTABLE); if (folio_test_slab(folio)) - u |= 1 << KPF_SLAB; + u |= BIT_ULL(KPF_SLAB); #if defined(CONFIG_PAGE_IDLE_FLAG) && defined(CONFIG_64BIT) u |= kpf_copy_bit(k, KPF_IDLE, PG_idle); #else if (ps.flags & PAGE_SNAPSHOT_PG_IDLE) - u |= 1 << KPF_IDLE; + u |= BIT_ULL(KPF_IDLE); #endif u |= kpf_copy_bit(k, KPF_LOCKED, PG_locked); @@ -227,14 +227,14 @@ u64 stable_page_flags(const struct page *page) #define SWAPCACHE ((1 << PG_swapbacked) | (1 << PG_swapcache)) if ((k & SWAPCACHE) == SWAPCACHE) - u |= 1 << KPF_SWAPCACHE; + u |= BIT_ULL(KPF_SWAPCACHE); u |= kpf_copy_bit(k, KPF_SWAPBACKED, PG_swapbacked); u |= kpf_copy_bit(k, KPF_UNEVICTABLE, PG_unevictable); u |= kpf_copy_bit(k, KPF_MLOCKED, PG_mlocked); #ifdef CONFIG_MEMORY_FAILURE - if (u & (1 << KPF_HUGE)) + if (u & BIT_ULL(KPF_HUGE)) u |= kpf_copy_bit(k, KPF_HWPOISON, PG_hwpoison); else u |= kpf_copy_bit(ps.page_snapshot.flags.f, KPF_HWPOISON, PG_hwpoison); -- 2.43.0