From: Christoph Hellwig <hch@lst.de>
To: changfengnan <changfengnan@bytedance.com>
Cc: Joanne Koong <joannelkoong@gmail.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>, Carlos Maiolino <cem@kernel.org>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw
Date: Thu, 23 Jul 2026 06:55:17 +0200 [thread overview]
Message-ID: <20260723045517.GB6641@lst.de> (raw)
In-Reply-To: <d9210bcdf73fbe1ac8b6ec132865609a3ed68688.fb281486.dc82.4049.92e1.5b912f7e663c@bytedance.com>
On Thu, Jul 23, 2026 at 10:17:49AM +0800, changfengnan wrote:
> Yes, there is an issue with the handling of the inode_dio_end event in the
> synchronization scenario.
> How about this ?
Yes, minus the label naming that is exactly what I came up with
yesterday and it has survived testing over night. Looks like xfstests
currently never triggers the sychronous error return path, I'll see
if I can increase coverage for that.
next prev parent reply other threads:[~2026-07-23 4:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 12:49 decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-22 12:49 ` [PATCH 1/3] iomap: split iomap_iter() logic into iomap_iter_next() Christoph Hellwig
2026-07-23 2:06 ` changfengnan
2026-07-22 12:49 ` [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
2026-07-22 19:03 ` Joanne Koong
2026-07-23 2:17 ` changfengnan
2026-07-23 4:55 ` Christoph Hellwig [this message]
2026-07-23 4:53 ` Christoph Hellwig
2026-07-22 12:49 ` [PATCH 3/3] iomap: use GFP_NOWAIT when application for iomap_dio_simple allocations Christoph Hellwig
2026-07-22 21:01 ` Joanne Koong
2026-07-23 2:06 ` changfengnan
-- strict thread matches above, loose matches on Subject: below --
2026-07-23 5:01 decouple simple direct I/O reads from iomap_dio_rw v2 Christoph Hellwig
2026-07-23 5:01 ` [PATCH 2/3] iomap: decouple simple direct I/O reads from iomap_dio_rw Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723045517.GB6641@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=changfengnan@bytedance.com \
--cc=djwong@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox