Re: URGENT BUGS TO FIX IN THE FILE SYSTEM, KERNEL PANICS, INT OVERFLOWS, ETC.

[David Sterba <dsterba@suse.cz>]

On Wed, Jul 29, 2026 at 05:15:46PM -0700, Linus Torvalds wrote:
> Please do proper kernel bug reporting, which means "don't just sent to
> Linus", but figure out the maintainer etc. We have documentation about
> this all.
> 
> That filesystem isn't a serious filesystem, and that code needs a lot
> more fixing if somebody cares.
> 
> Instead of doing
> 
>         if (affs_validblock(sb, block)) {
>                 bh = sb_getblk(sb, block);
> 
> it should probably just do
> 
>         bh = affs_getblk(sb, block);
>         if (bh) {
> 
> instead, but honestly, I can't find it in myself to care about an
> unlikely error case that nobody has ever seen and reported, all in a
> legacy Amiga filesystem that nobody really uses outside of hobby Amiga
> enthusiasts.
> 
> But we do have a listed sucker^Hmaintainer for it that says "Odd
> Fixes", and this certainly counts as an odd fix.
> 
> So I'm cc'ing David and fsdevel in case there is somebody else with an
> Amiga background.

Thanks, I have a few more pending AFFS fixes, but nothing serious so
it's in the backlog. The last fix from the community was in 2020
d3a84a8d0dde4e ("affs: fix basic permission bits to actually work"). The
rest is tree-wide and recently the AI assisted reports.

> Me, I'm still bitter about those rich kids with their fancy sprites on
> their Amiga HW, which may be one reason I don't feel like fixing the
> problems in AFFS ;)

For me it was only a ZX Spectrum on a grayscale 12" TV, blissfully unaware.