Linux filesystem development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shigeru Yoshida <syoshida@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Eric Sandeen <sandeen@redhat.com>,
	linux-fsdevel@vger.kernel.org, driver-core@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devtmpfs: apply mount options to the existing superblock
Date: Mon, 24 Aug 2026 07:08:01 +0200	[thread overview]
Message-ID: <2026082445-illusion-overtake-cacc@gregkh> (raw)
In-Reply-To: <20260823191254.3696641-1-syoshida@redhat.com>

On Mon, Aug 24, 2026 at 04:12:53AM +0900, Shigeru Yoshida wrote:
> Commit cb0e0a8bf4e1 ("devtmpfs: replace ->mount with ->get_tree in
> public instance") dropped the reconfigure_single() call that
> public_dev_mount() used to apply the options of every new mount to the
> single, internally created superblock. devtmpfs_get_tree() only takes
> a reference on it: the options are still parsed into fc->fs_private,
> but ->reconfigure is now only reached via reconfigure_super(), i.e. on
> remount, so they are discarded by put_fs_context().
> 
> For example, systemd mounts /dev with "-o mode=755,size=4m,nr_inodes=1m",
> so size= is silently ignored and /dev falls back to the tmpfs default of
> 50% of physical RAM.
> 
> Call the underlying ->reconfigure from devtmpfs_get_tree(), the same
> way tracefs and debugfs do; ramfs has no ->reconfigure, hence the NULL
> check.
> 
> This restores the behaviour of commit a6097180d884 ("devtmpfs
> regression fix: reconfigure on each mount"), which fixed the same
> regression when devtmpfs was first converted away from mount_single().
> 
> Fixes: cb0e0a8bf4e1 ("devtmpfs: replace ->mount with ->get_tree in public instance")
> Cc: stable@vger.kernel.org
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
> ---
>  drivers/base/devtmpfs.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

Isn't this solved with this series:
	https://lore.kernel.org/r/20260810083438.764684-1-simonlie@amazon.de
?

thanks,

greg k-h

      reply	other threads:[~2026-08-24  5:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-23 19:12 [PATCH] devtmpfs: apply mount options to the existing superblock Shigeru Yoshida
2026-08-24  5:08 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026082445-illusion-overtake-cacc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=brauner@kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sandeen@redhat.com \
    --cc=syoshida@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox