From: Breno Leitao <leitao@debian.org>
To: Shuah Khan <shuah@kernel.org>, Andreas Hindborg <a.hindborg@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
gustavold@gmail.com, linux-fsdevel@vger.kernel.org,
Breno Leitao <leitao@debian.org>,
kernel-team@meta.com, vasilisalmpanis@gmail.com
Subject: [PATCH 0/4] configfs: add a basic selftest
Date: Wed, 26 Aug 2026 03:47:01 -0700 [thread overview]
Message-ID: <20260826-config_selftest-v1-0-e364b07e91ac@debian.org> (raw)
configfs has had no selftest since day one, which makes maintaining it
harder than it needs to be.
The good news is that it is not hard to test: nearly all of it is
reachable from userspace through mkdir/rmdir/read/write and symlink(2).
This series leverages the sample configfs module to do exactly that.
The sample implements no ->allow_link(), so patch 2 adds a subsystem that
accepts symlinks and patches 3 and 4 build the symlink coverage on it.
Patch 4 races symlink(2) against rmdir(2) of the target and reproduces the
use-after-free syzbot reported, so it fails until these patch land:
1507d5b57e40 ("configfs: pin the symlink target's dirent instead of chasing ->ci_dentry")
2251d0ed97c2 ("configfs: unhash the dentry before dropping the item in rmdir")
Both are in configfs-next. The first trips the s_count WARN_ON()
in configfs_get(), the second the KASAN use-after-free in
config_item_get().
Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (4):
selftests/configfs: add tests for the userspace interface
samples/configfs: add a subsystem that accepts symlinks
selftests/configfs: cover symlink and unlink
selftests/configfs: race symlink against rmdir of the target
MAINTAINERS | 1 +
samples/configfs/configfs_sample.c | 121 ++++++
tools/testing/selftests/Makefile | 1 +
.../selftests/filesystems/configfs/.gitignore | 2 +
.../selftests/filesystems/configfs/Makefile | 8 +
.../testing/selftests/filesystems/configfs/config | 5 +
.../selftests/filesystems/configfs/configfs_test.c | 481 +++++++++++++++++++++
7 files changed, 619 insertions(+)
---
base-commit: a8406e6c0b793ce0788019683837c40855b55995
change-id: 20260826-config_selftest-9d84a5b1ec26
Best regards,
--
Breno Leitao <leitao@debian.org>
next reply other threads:[~2026-08-26 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 10:47 Breno Leitao [this message]
2026-08-26 10:47 ` [PATCH 1/4] selftests/configfs: add tests for the userspace interface Breno Leitao
2026-08-26 10:47 ` [PATCH 2/4] samples/configfs: add a subsystem that accepts symlinks Breno Leitao
2026-08-26 10:47 ` [PATCH 3/4] selftests/configfs: cover symlink and unlink Breno Leitao
2026-08-26 10:47 ` [PATCH 4/4] selftests/configfs: race symlink against rmdir of the target Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826-config_selftest-v1-0-e364b07e91ac@debian.org \
--to=leitao@debian.org \
--cc=a.hindborg@kernel.org \
--cc=gustavold@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vasilisalmpanis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox