From: Christian Brauner <brauner@kernel.org>
To: Sun Jian <sun.jian.kdev@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>,
jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
tasos.papagiannnis@gmail.com, kees@kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH bpf-next] exec: Drop bprm loader before closing bprm->file
Date: Thu, 3 Sep 2026 09:24:53 +0200 [thread overview]
Message-ID: <20260903-normung-opfer-matten-d29bbd55cf46@brauner> (raw)
In-Reply-To: <20260901114011.112375-1-sun.jian.kdev@gmail.com>
On Tue, 01 Sep 2026 04:40:11 -0700, Sun Jian wrote:
> free_bprm() currently drops what may be the final reference to
> bprm->file before calling bprm_drop_loader(). Since
> bprm_drop_loader() is attachable via BPF fentry and bprm->file is
> exposed as a BTF_TYPE_SAFE_TRUSTED pointer, the file can be observed
> after its reference has been released.
>
> Move bprm_drop_loader() before do_close_execat(bprm->file), keeping
> the file reference held while the hook runs. This preserves the
> existing trusted BTF contract without changing verifier behavior.
>
> [...]
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] exec: Drop bprm loader before closing bprm->file
https://git.kernel.org/vfs/vfs/c/115bf3e51538
prev parent reply other threads:[~2026-09-03 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 11:40 [PATCH bpf-next] exec: Drop bprm loader before closing bprm->file Sun Jian
2026-09-03 7:24 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903-normung-opfer-matten-d29bbd55cf46@brauner \
--to=brauner@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sun.jian.kdev@gmail.com \
--cc=tasos.papagiannnis@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox