Linux filesystem development
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	 Benjamin Peterson <benjamin@locrian.net>,
	Jann Horn <jannh@google.com>
Cc: Jan Kara <jack@suse.cz>, Arjan van de Ven <arjan@linux.intel.com>,
	 "Eric W. Biederman" <ebiederm@xmission.com>,
	Jake Edge <jake@lwn.net>,
	 linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH] exec: do_close_on_exec() before taking exec_update_lock
Date: Wed, 09 Sep 2026 09:48:06 +0200	[thread overview]
Message-ID: <20260909-glossar-filter-sorten-0cd07b1e8ad0@brauner> (raw)
In-Reply-To: <20260907-cloexec-before-exec-update-lock-v1-1-8018c201a7df@google.com>

On Mon, 07 Sep 2026 23:26:32 +0200, Jann Horn wrote:
> do_close_on_exec() currently happens while holding the exec_update_lock,
> which is used in a lot of places that access process state to
> synchronize access checks.
> I recently added another such use of exec_update_lock, causing a
> regression.
> 
> do_close_on_exec() can block waiting for a reply from a filesystem.
> That means a hung filesystem can block codepaths that use
> exec_update_lock; and it also means that a FUSE filesystem which
> attempts to inspect the calling process can deadlock.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] exec: do_close_on_exec() before taking exec_update_lock
      https://git.kernel.org/vfs/vfs/c/e780259b54e6


  parent reply	other threads:[~2026-09-09  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 21:26 [PATCH] exec: do_close_on_exec() before taking exec_update_lock Jann Horn
2026-09-08 10:20 ` Jan Kara
2026-09-08 16:45 ` Benjamin Peterson
2026-09-09  7:48 ` Christian Brauner [this message]
2026-09-11 11:30 ` Eric W. Biederman
2026-09-11 15:11   ` Jann Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909-glossar-filter-sorten-0cd07b1e8ad0@brauner \
    --to=brauner@kernel.org \
    --cc=arjan@linux.intel.com \
    --cc=benjamin@locrian.net \
    --cc=ebiederm@xmission.com \
    --cc=jack@suse.cz \
    --cc=jake@lwn.net \
    --cc=jannh@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox