From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
Carlos Maiolino <cem@kernel.org>,
Tal Zussman <tz2294@columbia.edu>,
Anuj Gupta <anuj20.g@samsung.com>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 03/16] block: add a bio_prepare_reissue helper
Date: Wed, 9 Sep 2026 09:05:01 -0700 [thread overview]
Message-ID: <20260909160501.GI2619314@frogsfrogsfrogs> (raw)
In-Reply-To: <20260909060924.1102037-4-hch@lst.de>
On Wed, Sep 09, 2026 at 09:08:52AM +0300, Christoph Hellwig wrote:
> Add a helper to a clear a bio for reissue without a lot of the
> pointless clearing and reinitializing done by bio_reset and bio_reuse,
> and keeping the page pinning flag intact.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> block/bio.c | 20 ++++++++++++++++++++
> include/linux/bio.h | 1 +
> 2 files changed, 21 insertions(+)
>
> diff --git a/block/bio.c b/block/bio.c
> index 5792a059ef2a..7f7654e60dd4 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -320,6 +320,26 @@ void bio_reuse(struct bio *bio, blk_opf_t opf)
> }
> EXPORT_SYMBOL_GPL(bio_reuse);
>
> +/**
> + * bio_prepare_reissue - prepare a bio for reuissing the original I/O
> + * @bio: bio to reuse
> + * @bdev: block device to use the bio for
> + *
> + * Prepare @bio to be resubmitted to retry the original operation.
> + * The caller must reset bio->bi_iter to the original state.
> + */
> +void bio_prepare_reissue(struct bio *bio, struct block_device *bdev)
> +{
> + bio->bi_bdev = bdev;
> + bio_associate_blkg(bio);
> + bio->bi_flags &=
> + (BIO_PAGE_PINNED | BIO_CLONED | BIO_QUIET | BIO_REFFED);
> + bio->bi_status = BLK_STS_OK;
> + bio->bi_bvec_gap_bit = 0;
> + atomic_set(&bio->__bi_remaining, 1);
> +}
> +EXPORT_SYMBOL_GPL(bio_prepare_reissue);
> +
> static struct bio *__bio_chain_endio(struct bio *bio)
> {
> struct bio *parent = bio->bi_private;
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 584b6abf6baf..bfa3c0e97b6f 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -479,6 +479,7 @@ static inline void bio_init_inline(struct bio *bio, struct block_device *bdev,
> extern void bio_uninit(struct bio *);
> void bio_reset(struct bio *bio, struct block_device *bdev, blk_opf_t opf);
> void bio_reuse(struct bio *bio, blk_opf_t opf);
> +void bio_prepare_reissue(struct bio *bio, struct block_device *bdev);
> void bio_chain(struct bio *, struct bio *);
> void bio_await(struct bio *bio, void *priv,
> void (*submit)(struct bio *bio, void *priv));
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-09-09 16:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:08 lazy bounce buffering for checksummed reads v3 Christoph Hellwig
2026-09-09 6:08 ` [PATCH 01/16] block: split bio_iov_iter_bounce_write Christoph Hellwig
2026-09-09 6:08 ` [PATCH 02/16] block: export fs_bio_integrity_{alloc,free} Christoph Hellwig
2026-09-09 6:08 ` [PATCH 03/16] block: add a bio_prepare_reissue helper Christoph Hellwig
2026-09-09 16:05 ` Darrick J. Wong [this message]
2026-09-09 6:08 ` [PATCH 04/16] iomap: respect maximum I/O size in iomap_dio_bio_iter_one Christoph Hellwig
2026-09-09 6:08 ` [PATCH 05/16] iomap: add a iomap_ioend_flags helper Christoph Hellwig
2026-09-09 6:08 ` [PATCH 06/16] iomap: add a IOMAP_IOEND_INTEGRITY flag Christoph Hellwig
2026-09-09 6:08 ` [PATCH 07/16] iomap,xfs: move T10 PI handling for direct I/O into ->submit_io Christoph Hellwig
2026-09-09 6:08 ` [PATCH 08/16] xfs: move PI generation into xfs_submit_zoned_bio Christoph Hellwig
2026-09-09 16:06 ` Darrick J. Wong
2026-09-09 6:08 ` [PATCH 09/16] block,iomap: fix protection information verification with initial bvec offset Christoph Hellwig
2026-09-09 6:08 ` [PATCH 10/16] iomap: better read bounce buffering support Christoph Hellwig
2026-09-09 6:09 ` [PATCH 11/16] xfs: use BIO_COMPLETE_IN_TASK for bounce buffered read I/Os Christoph Hellwig
2026-09-09 6:09 ` [PATCH 12/16] iomap,xfs: move integrity verification to the file system Christoph Hellwig
2026-09-09 6:09 ` [PATCH 13/16] xfs: add support for lazy direct read bounce buffering Christoph Hellwig
2026-09-09 6:09 ` [PATCH 14/16] xfs: add error injection for lazy " Christoph Hellwig
2026-09-09 6:09 ` [PATCH 15/16] xfs: log a message at mount time when using integrity protection Christoph Hellwig
2026-09-09 6:09 ` [PATCH 16/16] block,iomap: remove the old read side bounce buffering support Christoph Hellwig
2026-09-09 16:15 ` Darrick J. Wong
2026-09-10 20:50 ` lazy bounce buffering for checksummed reads v3 Jens Axboe
2026-09-10 20:51 ` Jens Axboe
2026-09-11 3:57 ` Anuj gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909160501.GI2619314@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox