From: Viacheslav Dubeyko <slava@dubeyko.com>
To: zlang@redhat.com, fstests@vger.kernel.org
Cc: glaubitz@physik.fu-berlin.de, vdubeyko@coreweave.com,
linux-fsdevel@vger.kernel.org, frank.li@vivo.com,
Viacheslav Dubeyko <slava@dubeyko.com>
Subject: [PATCH] xfstests: exclude hfs/hfsplus from generic/339 run
Date: Wed, 9 Sep 2026 17:04:50 -0700 [thread overview]
Message-ID: <20260910000449.747189-2-slava@dubeyko.com> (raw)
The dirhash_collide generates filenames from arbitrary random
bytes (only '.' and '/' are filtered out), which are not valid
UTF-8 in general. Catalog names on both classic HFS and HFS+ are
Unicode. Feeding random bytes causes fsck to report "Illegal name"
or catalog corruption that has nothing to do with directory
hash-collision handling, which is what this test is actually meant
to exercise.
This patch excludes HFS/HFS+ file systems from generic/339 run.
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
---
tests/generic/339 | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/generic/339 b/tests/generic/339
index bf8f7729..5cc1086f 100755
--- a/tests/generic/339
+++ b/tests/generic/339
@@ -17,6 +17,15 @@ _begin_fstest auto dir
_require_scratch
_require_test_program "dirhash_collide"
+# dirhash_collide generates filenames from arbitrary random bytes (only
+# '.' and '/' are filtered out), which are not valid UTF-8 in general.
+# Catalog names on both classic HFS and HFS+ are Unicode. Feeding random
+# bytes causes fsck to report "Illegal name" / catalog corruption that has
+# nothing to do with directory hash-collision handling, which is what this
+# test is actually meant to exercise.
+_exclude_fs hfs
+_exclude_fs hfsplus
+
_scratch_mkfs >>$seqres.full 2>&1
_scratch_mount
--
2.43.0
next reply other threads:[~2026-09-10 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 0:04 Viacheslav Dubeyko [this message]
2026-09-10 9:57 ` [PATCH] xfstests: exclude hfs/hfsplus from generic/339 run Christoph Hellwig
2026-09-10 13:49 ` Theodore Tso
2026-09-10 21:14 ` Viacheslav Dubeyko
2026-09-11 14:48 ` Theodore Tso
2026-09-10 20:13 ` Viacheslav Dubeyko
2026-09-11 7:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910000449.747189-2-slava@dubeyko.com \
--to=slava@dubeyko.com \
--cc=frank.li@vivo.com \
--cc=fstests@vger.kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vdubeyko@coreweave.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox