From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B455E42E414 for ; Thu, 24 Sep 2026 07:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790235568; cv=none; b=HU/ZFaMMXM41AOSLcxekQ5/KrNs4MsSKM+BFLIpiWwBf3rHITuL8jB6liML1k8QCb+rmKEvi15DVh4jbI6jG6FPerESfm8sbr5wA4gh+S9XVXkHzSK1DXR4YIv1+5YqpDQoEIL0QbDzFjM1Q0rtlocKszyY98wv/VAr25wtzT2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790235568; c=relaxed/simple; bh=+VlMZOALNoTVxwvqqOHNg+HWbZydFH9BbG4DHncGqes=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YIt45yJUcf3iSV/7acB2I5Ab5wVKhiZ7wZvJMmSUA8lr28Q6MXlGy7wCk6oEaqdBLajzeHp8u2Ut4+RwwsDcE6qoGNnPQzMzElbUL9pvKLEDaQoXfo+GOepbwSFFljJR+dqVsgoZJZez9qimaX3AznrqeaR/CZAkZkOAhrvSJAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R51z4+HG; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R51z4+HG" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-8692a856865so790019b3a.2 for ; Thu, 24 Sep 2026 00:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790235564; x=1790840364; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n6HiNqskXz+7GrxS6wHzPZKAwsfj0AyVFsyoKCtHJ2g=; b=R51z4+HGI4YrJz66Hz+x2kyZfwba06+ypVMpHRr7/N73oDAvic/658S8bxQznNOD6i QXL2nzcbWdH2djR0Qf2A0qpcM4HeoafOzjDY6ys3PEUGZY9f3+v1qayrF2yBqVxNEial sOX2wfFbI+0zzqoe73tHHc3YGXUiL87ai1IUGXoO7fYBjM9huXlnX2hpBSuLfcTQk578 oQYaooc1CLRgt/KaYB7U9Gi1GP94z6UhO7Fzg7u0RNmy2jnB/7KDF2AJDBnyYoaAN2zS Cmn8IuO5tZ/zs9U345Iyr437NMt6HhMqP5fdfXk5HmS7x8mgu0lCG8R8K7W0E6dCKU/g 3Y7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790235564; x=1790840364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=n6HiNqskXz+7GrxS6wHzPZKAwsfj0AyVFsyoKCtHJ2g=; b=BeaCClQ7zbGLVshxpWXPN6l8fTg6xwTLBMUT3J66obHli+aT9X73FBqRVjDIgo1I3k ZH2DdsEzYkZIy7DDewLw1sDcQNJlyXzUJKG7elfrlKs8iDfxeYk46trve+/xY9hvE6aI WbIZMk9syW2NoFg2ltSC3TwkBtb8oWGDe2zAO4jOJ+5a/A+w0jQC+WBT/aj3fAy9YkoX L4p0QbF4uEXEufMOHpwn07cRy8N8WbLnr5ilNTvPZcQpf5Fp/f3+a72PWIehIDjOImuN ug8ZLBf33skwk7/SYzl9V/VSYLFN7reAS7ph1uB8+Kuy3Bn3pIy1aI42Yccc0Kg/9le5 dLSA== X-Gm-Message-State: AFuF++nJ2Cbe11gQzSNlf40XAjQ3GNMz0uD8Nzs/P3kC8nbNZftJjOT8 aI+yd5pr3Gr7UGt46Ckk9fajQKWyy39FdYxrw6Efv7cqD0WF+F9N7OAC X-Gm-Gg: AYBFou32kiRKUlIJjyRvXF+56PJtn8AihQDGzgAaB7rdR1Vg2byNDozIbeymaTBiJGN B90U5OnKCqP1UAdsG8+SCLe/zi2mYei4lCGv4ISG46Jevt/OYS5drSB5zbRa6Zh+Lxn3B8+VB5W QHnYH0ZIJQODyPGfd45cdiyZDCuBHL5Sfm6wfB7dnG6yWQbR38NnkTK3/P3X09wVkQgTzTlhgt1 csMqRL8mD97BGCj1qOtmO+51dRfC1To9YvoLl99PpvZc5OZBcXw9TG+ISaR9ww7pk5IfuFXlecH /xPnqQ1kRpdm3GiewPSFwXjLqSJ8HDtpd3DOJFqNWUKFA6EiF4janqXyff/1DV5idBznPR08wC/ 7GZgKVNA8hx4jmesKxdJTgGL7bOKIejjvPD8mPh7ogORBEWhO0amGoxyWqQXFhLxbf28CsgrCmq G1WfubbuEYByV4udf5dsnVmFrXj51KnsodIEtb1ewWmF094Uabnz8XFlQtGex+bxXo9weJMZwEV UwjnkL6yuDThG+j0FEF4MbB9C38CoY8jllAvelCdVRArZ38IUsw1eFx8spDqm0mizui4kGWc4YZ YQ+LIrH/xtc= X-Received: by 2002:a05:6a00:90a8:b0:86b:4138:4084 with SMTP id d2e1a72fcca58-87e98f8ccd4mr1408808b3a.15.1790235563675; Thu, 24 Sep 2026 00:39:23 -0700 (PDT) Received: from phui-2.c.googlers.com.com (67.51.127.34.bc.googleusercontent.com. [34.127.51.67]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-87d1dad44c6sm2393739b3a.42.2026.09.24.00.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 00:39:23 -0700 (PDT) From: Hui Peng To: al@alarsen.net Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, matthias.goergens@gmail.com, Hui Peng Subject: [PATCH v3 4/6] qnx6: release sb_buf on mmi_fs error path in qnx6_fill_super() Date: Thu, 24 Sep 2026 07:39:17 +0000 Message-ID: <20260924073920.2782917-5-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.310.g51773c2048-goog In-Reply-To: <20260921042511.1473629-5-benquike@gmail.com> References: <20260921042511.1473629-1-benquike@gmail.com> <20260921042511.1473629-5-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In qnx6_fill_super(), when standard qnx6 superblock detection fails, the driver attempts to probe for an MMI variant via qnx6_mmi_fill_super(s, silent). If qnx6_mmi_fill_super() fails, qnx6_fill_super() returns -EINVAL directly without releasing sb_buf (which was allocated by sb_bread(sb, 1) earlier), leaking the buffer head reference. Call brelse(sb_buf) on the qnx6_mmi_fill_super() error path in qnx6_fill_super(). Fixes: 5d026c724220 ("fs: initial qnx6fs addition") Cc: stable@vger.kernel.org Tested-by: Matthias Goergens Reviewed-by: Matthias Goergens Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - Add Tested-by and Reviewed-by tags from Matthias Goergens. - Update Fixes: tag SHA to 5d026c724220 ("fs: initial qnx6fs addition"). Changes in v2: - Split out as patch 4/6 as requested by maintainers. fs/qnx6/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c index 70438cf5efdf..49e29a918a2d 100644 --- a/fs/qnx6/inode.c +++ b/fs/qnx6/inode.c @@ -340,8 +340,10 @@ static int qnx6_fill_super(struct super_block *s, void *data, int silent) } } if (!sb_buf) { - if (qnx6_mmi_fill_super(s, silent)) + if (qnx6_mmi_fill_super(s, silent)) { + brelse(sb_buf); return -EINVAL; + } return 0; } -- 2.55.0.1082.g2b9226bbc0-goog