From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 032311A680C for ; Fri, 16 Oct 2026 00:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792109693; cv=none; b=gtsiAw9FOSoBx0rRQsL6+HFgg8revJXp4otrLrXg8Tg/es5DaawDZrgvjzegEZepttWEMUWo7OwRPZTN6/f+AuXyPbYdBmjGZbzcMh/2RwmZq/Cx5rGFvaJro7Ymf/JEm1Fqp/0GH7xqaB0PbxNTS0QKh+KDk1hXmTkXX8WfyCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792109693; c=relaxed/simple; bh=N3hAyy7nTu0uD6uxxEosrsvSAc05WwQLSTSIID6INNQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oQL4ihDAGmXWvS783iA18OArqFb6kN/OAbu65qwzlQJiTYgUVpb7l8ls0Il5N197RVMZ7Xuhr2xKyfHqH6bIqwbBfSiQyvNjfGkSVS6A4CcTgBsHE7Pj9YFR+XPoym8V80TD3jOjo6N/9xQ0hrZIBGS8zCpo/fz75ioJjAa/AAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=T/StiSJg; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="T/StiSJg" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-5351d76e1baso5829911cf.1 for ; Thu, 15 Oct 2026 17:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1792109691; x=1792714491; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=V2saNd2pf5xXpmgizEGMG+P83blHZRupazL/vtIJhv4=; b=T/StiSJg9NKkj9ibcSWBMEe5hjKjl5QSwtnEiP3tJzvpn/R0nSFhQSE2BteEpHDzDF 4uRGBFJHEJaC8NsxylpA+ABes7IxI2+87ROJ6dQn0dhETh3oLKejUQcI3XVrCeooZ0jN LBuzzRkKgdH7XqHEVZM1mVh+4VYM5srvaGbH7cRqoiS+NpWHcQ3PPJ8hSNCRl3zf0jSx OC8glC/BwOAeoVt/aqPc6qBd/KOujSyKOKYhxMVH9idVTMQYEAS0+Dk3trwFqSQzgoDP Ukq63JkewdwSwFPWIY5gvBVoi5Iy7viGPaetFhiagl3amNV78U7Bh5Yi+uua5qHdSPpB aUIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792109691; x=1792714491; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V2saNd2pf5xXpmgizEGMG+P83blHZRupazL/vtIJhv4=; b=qjFP8SEwh7OmjhgdBjM0Pkn52tNwPKK9m+LTYgdpkYkT3a51T2o4OK908J5jFlltoY FejiVFeiI6/HdzIETLX8hhH5/A4gFyMVvaQi2B8EIinpoHlTq6ymPPSfuGg+m3cYCGzR JXyaqiB6wWx4gV7K7B7ZPQtCZAuDVt1SlHEOf4cOMomFDSyIlqMZmRvpaacSTUQmRlkn GtH+MwgVBnJKunQNvEWlnMfuZwTmEqJHs481QOW5IYqAzGYAr/SZbBzc2HW3TO+TNB4A AKW15Okm0DqqV4xCXaYVaIrmcqXRCPs2Y53afH29TeY68jqFQFS3O8v2uDFKIFvR6N3j ZzRQ== X-Forwarded-Encrypted: i=1; AKwUvBw7RG5WkEw9iCEFhRxBKoNdDTWLH/DA5RegWQNnTZACbkZ6S4AlslrKvAwVo2hZa8DQON6uHf7yvJOCGIFy@vger.kernel.org X-Gm-Message-State: AFq9FYIjNVFw7fDvW5hoBvzpyEuaED0ag+QdTRB8+My3krR+tWmvdDsC Ma6V/0+G8cwzBHl29aMSoIr+qwlfkXTqhuayY6iwnIGVCyE2lBLDIB6Yw7TejCIFO9c= X-Gm-Gg: AYBFou1gdMlE9GmV6XCzJ7T0jNwcXAKHByiPTAFc/0vPB2JWAzkjXVXJNWTOo9f+cOf NC6fq/RoYdepnmtamNlVhdEvdr0dipA1mdEZwjywaCO/mqPDl2A9aXu5jrUoRNY1sHMnjrxMCvZ CyktH9DQOjpRmKYhBd7ikgMdxveIL/DXDiIvqw9RSsggaKXnp41GjfgwpK1Ugtd10WFDXi532uI ixeJXEY7212zmO9tfQfF2DJvMztempakvMRdmTzeS9L+gWBm86CmkKDfCiQ+I/Dh0Db/fU+trPu e+K2Iiwa9axYTvobvWAty7KtfH5ocBizjP2MKIhoQrr876V8t6hVxeiERG1tlortQa4FgU68PfJ osfdfyMYOowz7CpTglfZH1AWCeeDRn9J8fMdMHt36iLRdN5kwFOmJDUf2+D6bUMW1Q/n9LPXiY6 7/cCoLC4aghe7l46VGCxStRELrg3/zHopqvoAeIKeLtQJuZ+ZXMpWW+XDk4mvTrMAPtCOEfg7I+ SpWDzg7NIRZK6GLhbuiqeXF4OVSirmsVKvPy0Ot5GSBMxZD3m5gMF1i X-Received: by 2002:a05:622a:990:b0:535:ba01:d95 with SMTP id d75a77b69052e-536272c2d55mr30900421cf.19.1792109690637; Thu, 15 Oct 2026 17:14:50 -0700 (PDT) Received: from ziepe.ca (hlfxns010zw-159-2-239-150.pppoe-dynamic.high-speed.ns.bellaliant.net. [159.2.239.150]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5362aa57106sm7257071cf.28.2026.10.15.17.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 17:14:49 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1xHVay-00000000IxD-2c33; Thu, 15 Oct 2026 21:14:48 -0300 Date: Thu, 15 Oct 2026 21:14:48 -0300 From: Jason Gunthorpe To: Fred Griffoul Cc: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Oliver Upton , Catalin Marinas , Andrew Morton , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Jonathan Corbet , Shuah Khan , Shuah Khan , David Woodhouse , Ackerley Tng , "Aneesh Kumar K . V" , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Steffen Eiden , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC PATCH v2 07/11] iommufd: Use large IOMMU pages for provider mappings Message-ID: <20261016001448.GC14213@ziepe.ca> References: <20261014093733.90312-1-griffoul@gmail.com> <20261014093733.90312-8-griffoul@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014093733.90312-8-griffoul@gmail.com> On Wed, Oct 14, 2026 at 09:37:29AM +0000, Fred Griffoul wrote: > From: Fred Griffoul > > Provider pages are mapped with one PAGE_SIZE entry each. A device that > uses a large provider block then misses in the IOTLB on every page, and > the IOMMU needs more page table memory than the block requires. A > revoke also flushes the IOTLB once per run of pages it unmaps. > > Map each block that the provider reports with large IOMMU pages where > the IOVA and the frames are aligned alike, and with smaller ones where > they are not. Only the pages of the block are mapped, as before. > > A large IOMMU page can only be unmapped whole, so a revoke that cuts > one widens its range to the whole page. It maps back what the provider > backs now, and a device may also fault on the rest of that page while > it is remapped. The widening finds the page with iova_to_phys(): > pages that only look like one large page make the revoke remap more > than it must, which is harmless. You are going to need to go into generic_pt and implement cut and a more suitable unmap to make this stuff work properly. We can't over unmap on conversions. > iommu_unmap() may not split the range of one map call either, and > virtio-iommu refuses to. Map each IOMMU page with its own call: the > widened range ends on IOMMU page boundaries, so it also ends on map > call boundaries. Also please don't write commit messages with AI. WTF is this even trying to say? The subject is "use large pages" and this text says "map each page with its own call" Jason