From: Eric Biggers <ebiggers@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@kernel.org>
Subject: Re: [PATCH 1/2] dcache: don't leave negative dentries in casefolded directories
Date: Sat, 24 Oct 2026 12:20:17 -0700 [thread overview]
Message-ID: <20261024192017.GG2553@quark> (raw)
In-Reply-To: <20261023-work-dcache-casefold-v1-1-1b0bd5c73a69@kernel.org>
On Fri, Oct 23, 2026 at 02:44:22PM +0200, Christian Brauner wrote:
> +static __always_inline bool d_delete_drop(struct dentry *dentry)
> +{
> + return dentry_negative_policy ||
> + IS_CASEFOLDED(d_inode(dentry->d_parent));
> +}
Should this also check IS_ENABLED(CONFIG_UNICODE), so there will be no
overhead when CONFIG_UNICODE=n?
- Eric
next prev parent reply other threads:[~2026-10-24 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 12:44 [PATCH 0/2] dcache: don't leave negative dentries in casefolded directories Christian Brauner
2026-10-23 12:44 ` [PATCH 1/2] " Christian Brauner
2026-10-24 19:20 ` Eric Biggers [this message]
2026-10-23 12:44 ` [PATCH 2/2] xfs: unhash a removed name in ascii-ci mode instead of invalidating it Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024192017.GG2553@quark \
--to=ebiggers@kernel.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=krisman@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox