From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793051581; b=pNZGOJ94hISskW5DtLdQ6Nyn/lYIUerpmaAYe697CE/6/+ESp55y3evsJ3enwVnBHjHq VoiBP3xq90ekytohgxn9shjXtpyOXb/PuPmFQnFEySxPwffA0oszZIaQVkDpp6TvmxKYU KkKo/LlC7LieySK9HxGzc8uspa2Kvu7MB2yPU017BSNU0wPtEHIupHuyErY/KuoDr01jR 4fV7GA+Ig21qh0Bei3Ps5uCqwvWjuAR3ieB2IRtrzWoDFkykpmRuhiy+FWtcQmahu1tCS NWkYRxYZey/AO8BRsCDOeKbHrab0w9dRtjJqy2u9bpUx0NL2pbsqyz6BhBxNa24VNsg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793051581; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=/8L34Uc9Xo1d4oJ1WUUvtNMd/yh9NNapi89sPDAfm6Y=; b=YAiUDr/xRLyrdYjzsPod/JSLkR0sxveva5iZGyNqPEbLbD3/gLSol/pFO9Y8H+MaV/D9 9nDJ6M7CqYcLEQqRsjsauD7x5CA82fkN5Ffzp2x2h7oCLCLOOaQpa/e3xCGPKT7Obs93N S7SI7Nst8bz8lecuL8L14c2GKD1w2QLtIDhpJ8FvRhMDu8pFX5bNEAxQy0MerxmlqqY0t tPkXta3xq95Tw8Ihr5E1zswvPyiNcXwrbuIZZBnxWlpI1s4KTC72m061BW3OSIhg5xRQ7 Te9UoOXIcy4KXH+qFEvgO9vvV39M0DgRNwkLdG+ea10Eu8mGRNUMQJ2WaNOCJodktog== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=(null) smtp.mailfrom=flex--jthoughton.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=fU7gA7Dl; arc=none smtp.remote-ip=209.85.215.200 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566EF60A2621 for ; Mon, 26 Oct 2026 21:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 566EF60A2621 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=tempfail smtp.mailfrom=flex--jthoughton.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=fU7gA7Dl Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cd6969473a4so2053546a12.0 for ; Mon, 26 Oct 2026 14:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793051570; x=1793656370; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/8L34Uc9Xo1d4oJ1WUUvtNMd/yh9NNapi89sPDAfm6Y=; b=fU7gA7DljvCqdvdMpaU2dp8kIrEccZFKOmWnfW6sw+A054S6dlNZugZLhIYYcfiePQ hsLgQW99gw7/40gSfJI6nU0rtnm0+1dPDbRaUoY665tdkjNVHr2UFbegtIbotfU9v9/A uK7QOilz2oAfaWXl/tsF91D3vAUMVrFCU+UmdWgUF2++tfRICFcImVM7cH8b81croIe/ 3gbPbeDpIxRnPDaXaoU22kL/RynJy6L0hYZfzyDRTzTeCDcQlDb8FUzF1BEGuZLmjKzH eeONqBOhxrAFnMU8HI0VT7oOvpOxL8LajgaOKQMUvvRXhW0M5pmi7s9QGStFhbTf6Lb8 9JRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793051570; x=1793656370; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/8L34Uc9Xo1d4oJ1WUUvtNMd/yh9NNapi89sPDAfm6Y=; b=hwlJE7Ak6K5pGiiu8MmCfaAete7On35L3Wjxy9a7IexTn7VzyBjX1uOHLJb54fCyvz dGoWfRpExAFWEGAhKjXY4e7Fs79OrZ08ayxFLXQY+o/Kxjh2lAqlEVerz1LfNJhoUt6x 18zHcPFrVtYRhr391fzIsESTAjjQHc1piY+U7bS9q4UENZ7WgpF6wvM/bn00Nd/fWnGv uwK10+rAEJtTuwAZQYt71CnUEFv0l8SiDIjW5UB2UH6xJUdZwreMCDPQb3lpkzjJm37Z vMt5SmNVYz7WCtW+MSiV6Pc+06OIbwS+/ouZyBkcJZPsJJ6VS24p4lnLeYIrLRH5wcsw uSrw== X-Forwarded-Encrypted: i=1; AKwUvBzuWLX1tTgyL18mcTmwwLxGNNy+Vjf+JdDANXtPL3ap2dXQeaCLaTp2/4GPRYTN9YA0/M1wcdrwLhl+rhKO@vger.kernel.org X-Gm-Message-State: AFq9FYKXhMKf0/sA9yJzPPWgOJsjrskgLCPeo5ZK1MTbmpz52sxIqR2x MxFDsyKkTSHDpXLvVCibdEYrhHjwRzlh9EMlu4TS+6ZsBP/UJZ5eYsPoVSEqGnJOOHkf5Pj7H+0 h0dHDZ7m2TW1xnls3deTR0A== X-Received: from pjbme4.prod.google.com ([2002:a17:90b:17c4:b0:3ae:349e:2bcd]) (user=jthoughton job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:35cc:b0:3ad:1b31:92d8 with SMTP id 98e67ed59e1d1-3adeb16ecffmr5865801a91.60.1793051569572; Mon, 26 Oct 2026 14:52:49 -0700 (PDT) Date: Mon, 26 Oct 2026 21:52:18 +0000 In-Reply-To: <20261026215226.3713941-1-jthoughton@google.com> X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261026215226.3713941-1-jthoughton@google.com> X-Mailer: git-send-email 2.56.0.307.g5fe7bd680c-goog Message-ID: <20261026215226.3713941-3-jthoughton@google.com> Subject: [RFC PATCH 02/10] btrfs: Don't copy encoded read data to user memory when canceled From: James Houghton To: Andrew Morton , Alexander Viro Cc: Thomas Gleixner , Peter Zijlstra , Kees Cook , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Sean Christopherson , Paolo Bonzini , Jim Mattson , Jens Axboe , Pavel Begunkov , "James E.J. Bottomley" , "Martin K. Petersen" , David Sterba , Chris Mason , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, io-uring@vger.kernel.org, linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Houghton Content-Type: text/plain; charset="UTF-8" btrfs_uring_read_finished() copies the data of an io_uring encoded read to the submitter's buffers with copy_page_to_iter(). It runs as io_uring task work, but io_uring may also run it with tw.cancel set from other contexts when the submitting task can't run it: from a kworker when the submitting task has exited (io_tctx_fallback_work()), or from io_cancel_local_task_work() when a DEFER_TASKRUN ring is torn down. In a kworker, current->mm is NULL, and the copy does not reliably fail: the user half of the address space belongs to whatever mm happens to be lazily loaded, if any, so the data may be written into an unrelated process. Don't copy the data when the task work is canceled, and complete the command with -ECANCELED. Fixes: 34310c442e17 ("btrfs: add io_uring command for encoded reads (ENCODED_READ ioctl)") Signed-off-by: James Houghton --- fs/btrfs/ioctl.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index f3e2afe221be..d9044fbd9547 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4609,6 +4609,16 @@ static void btrfs_uring_read_finished(struct io_tw_req tw_req, io_tw_token_t tw) goto out; } + /* + * If the request is being canceled, e.g. because the submitting task + * has exited, this may run from a kworker or in a different task, so + * don't copy the data to the submitter's buffers. + */ + if (unlikely(tw.cancel)) { + ret = -ECANCELED; + goto out; + } + if (priv->compressed) { index = 0; page_offset = 0; -- 2.56.0.307.g5fe7bd680c-goog