From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.198 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793051571; b=2b8DY0Fwsd9suy7FqgZZgbqgvqA9KlmpOdjxjASiq/HcnsFew1WFsrIqDXLRScfeDCFO ux+6emRWB4yNk/EC5EPUqNkWcXqC4m04nzVy47yP2C0iZQbhE3YxJJbDgpmXowXqut6IG KF5dO3QymcAzjj2DIrGuBEINyEt9nNMKzy/IR6KFbcJnSExj5qm67vNguTpwPhBl4k5pr Ns8llByPEuDLuieYaVJ21Kwbdtr3DgRjKuy3CdrHE9BqtpdD2pYRo04bqKBwTzcoaPMki cHDfNdAqvTAlgv3QTbY9Ez1U3nVwk6Np7Oz2IXh/hhz1exqXuw5jH+/Pv11/Y5kJEUg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793051571; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=oogWXdI71uSApWoisQtM4clnwhLv0Vs2bmtqChsuYec=; b=za3wgjnjP9Q8L3gEZwMLlRPs0eNM8Qp61P2leS4cpsGWJEJG0apPnZe/cthQR7yEhteI S2p50OLGBBN/rEbpaj08ZtkaJq2LQYHGCwgOGMGNaZgVg5/G5+/BYbVT5AVmM4pJnTBg8 38ZBF61jGORoRj7CbWP+hWCZPwaTxZqHlafc5Cf+VT7hnF0/7xCr5oRcRbi1/nl2CFth2 RRt9XnfvT+z0cOEWClwqzz2KYuFHUDBo/df5GOw+L+3FCbkBzqr1IbUOpdsEoPWMzVzUd z8N2pSlKQt+koKGFjqlKM52a/Xscl9Rc4uGiwHtyuxkEidcN19dYZcLYecUVrZcHg/g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=sJPCAyGd; arc=none smtp.remote-ip=209.85.215.198 Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24ED9606A31A for ; Mon, 26 Oct 2026 21:52:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 24ED9606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jthoughton.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=sJPCAyGd Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cd67e98f68fso4693130a12.3 for ; Mon, 26 Oct 2026 14:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793051570; x=1793656370; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oogWXdI71uSApWoisQtM4clnwhLv0Vs2bmtqChsuYec=; b=sJPCAyGdVEm2VhcvIBWqxKdB1ov+NEHAo0t+uGAM/0+qDIoJvuHm7nefnhKXLbxfZu kkzdd/4AnoA114yH/wBhWFkj4bhnTFD/5geQjiLBoAkwcMG8cTAN5yffgV7X8VZkSD6k UqJP6p4PAxwVl8yTZ/Y+9JixBhYbVYFxenEyF+y0YO2Y9TO0Q2mOae4aV4jUlpGMmFIH Y+Azcs1izJVTuxuoeh6BKO/iK8Vap0RGSadypMKvAjvOIsUEPKwpqHb793AvWJQkjEjp +fWxRFzb1QlgIgm+QlrlfCdAQHISYeGneT49/PFezT8s3UQeSh2Ep1POwSjeCezfL9SA lQ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793051570; x=1793656370; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oogWXdI71uSApWoisQtM4clnwhLv0Vs2bmtqChsuYec=; b=ijsUpdhMWYVAM/VxxrMEZBSuPBPQ/su4gWPkIUBVIJwaP06rFuTJHgK9CgIJ1HCo8q f/8le1ffff52McAOgbvYPli/+d5Dyh1pfFU6Ap6j0VYkYN7y/2e4I1ePVRJPA9V1jikh 7c5eizzBqzqQ4YBUiUUcS03RZiphL158bXq7oDbAqzSvnS4xiz+4zF8ZAEorwbzWfXCt 00QG9hoIf+aNQy2/PA9/bFPJsNHbBtI1aBDxkB4Kk9KTFAS8Z2Xc7psm0kmR7Bt0lwdz OQtRA52dNtyN6c7dMZrKrpWVm46oDWSvjWHqr+0QCRNLl9ab9yQqH3nRofgrNJu2ZdiM sYCQ== X-Forwarded-Encrypted: i=1; AKwUvBycTu8Egkel8i884nrsNFXoTaWwcAh9M6C9DdwHCVmuejhZJM/GUUf9AykMB7fuQDXjfRFH9A5dqKETLkh2@vger.kernel.org X-Gm-Message-State: AFq9FYKoOxIe8NUa9ZZJaVM4bFW3wDamUL7sKBL+vgeRod0rUdFhZsPW FQ8XxY/wAOeD5Lb5U1IJ5pf1BkwqvPvZJ4Os+eW4J/PDjlBczFKIvTJw8MSqz9RySlL956ni7w6 p1yUr1DLf7qZTVDJ+DkUbBQ== X-Received: from pjbml16.prod.google.com ([2002:a17:90b:3610:b0:3ab:54fb:2a3d]) (user=jthoughton job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:56ce:b0:3a8:9d0d:ca50 with SMTP id 98e67ed59e1d1-3adeaae618emr6704272a91.10.1793051570356; Mon, 26 Oct 2026 14:52:50 -0700 (PDT) Date: Mon, 26 Oct 2026 21:52:19 +0000 In-Reply-To: <20261026215226.3713941-1-jthoughton@google.com> X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261026215226.3713941-1-jthoughton@google.com> X-Mailer: git-send-email 2.56.0.307.g5fe7bd680c-goog Message-ID: <20261026215226.3713941-4-jthoughton@google.com> Subject: [RFC PATCH 03/10] bpf: Fail sleepable user copy helpers when current->mm is NULL From: James Houghton To: Andrew Morton , Alexander Viro Cc: Thomas Gleixner , Peter Zijlstra , Kees Cook , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Sean Christopherson , Paolo Bonzini , Jim Mattson , Jens Axboe , Pavel Begunkov , "James E.J. Bottomley" , "Martin K. Petersen" , David Sterba , Chris Mason , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Josh Poimboeuf , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, io-uring@vger.kernel.org, linux-scsi@vger.kernel.org, linux-btrfs@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Houghton Content-Type: text/plain; charset="UTF-8" Sleepable BPF programs can run on behalf of a kernel thread, or of a task that has already gone through exit_mm(). For example, bpf_wq callbacks always run from a kworker, bpf_task_work callbacks queued late enough run from exit_task_work(), and lsm.s or fentry.s programs may be attached to functions called during exit_files(), exit_task_work() or from kernel threads (e.g. security_file_release() from a kworker running delayed_fput()). In such contexts, bpf_copy_from_user(), bpf_copy_from_user_str() and bpf_copy_from_user{,_str}_dynptr() (when reading from the current task) call copy_from_user() or strncpy_from_user() without an mm. That access does not reliably fail: the user half of the address space belongs to whatever mm happens to be lazily loaded, if any, so the program may read another task's memory. As there is no user memory to read from in this case, fail with -EFAULT without attempting the access. Fixes: 07be4c4a3e7a ("bpf: Add bpf_copy_from_user() helper.") Fixes: 65ab5ac4df01 ("bpf: Add bpf_copy_from_user_str kfunc") Fixes: a498ee7576de ("bpf: Implement dynptr copy kfuncs") Signed-off-by: James Houghton --- Tested with a small bpf_wq reproducer: a SEC("syscall") program arms a bpf_wq whose callback (which runs in a kworker) calls bpf_copy_from_user() on an address in the loader. With the uaccess check from later in this series but without this patch, that triggers the new WARN from bpf_copy_from_user(); with this patch, the helper returns -EFAULT without warning. I can turn this into a selftest under tools/testing/selftests/bpf if that's useful. --- kernel/bpf/helpers.c | 11 +++++++++-- kernel/trace/bpf_trace.c | 4 ++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 712dca5a2c5b..c4aa8bcaf2bd 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -659,7 +659,11 @@ const struct bpf_func_proto bpf_event_output_data_proto = { BPF_CALL_3(bpf_copy_from_user, void *, dst, u32, size, const void __user *, user_ptr) { - int ret = copy_from_user(dst, user_ptr, size); + int ret = -EFAULT; + + /* Sleepable programs may run without an mm, e.g. on kernel threads. */ + if (likely(current->mm)) + ret = copy_from_user(dst, user_ptr, size); if (unlikely(ret)) { memset(dst, 0, size); @@ -3642,7 +3646,10 @@ __bpf_kfunc int bpf_copy_from_user_str(void *dst, u32 dst__sz, const void __user if (unlikely(!dst__sz)) return 0; - ret = strncpy_from_user(dst, unsafe_ptr__ign, dst__sz - 1); + if (unlikely(!current->mm)) + ret = -EFAULT; + else + ret = strncpy_from_user(dst, unsafe_ptr__ign, dst__sz - 1); if (ret < 0) { if (flags & BPF_F_PAD_ZEROS) memset((char *)dst, 0, dst__sz); diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 88c3b5b513ab..793fb3dce5f1 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -3556,6 +3556,8 @@ static __always_inline int copy_user_data_sleepable(void *dst, const void *unsaf int ret; if (!tsk) { /* Read from the current task */ + if (unlikely(!current->mm)) + return -EFAULT; ret = copy_from_user(dst, (const void __user *)unsafe_src, size); if (ret) return -EFAULT; @@ -3590,6 +3592,8 @@ static __always_inline int copy_user_str_sleepable(void *dst, const void *unsafe if (tsk) { ret = copy_remote_vm_str(tsk, (unsigned long)unsafe_src, dst, size, 0); + } else if (unlikely(!current->mm)) { + ret = -EFAULT; } else { ret = strncpy_from_user(dst, (const void __user *)unsafe_src, size - 1); /* strncpy_from_user does not guarantee NUL termination */ -- 2.56.0.307.g5fe7bd680c-goog