From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793140759; b=Gz32Col6jRbkuIyKzIxaTfUM/1a2p4YiTXClls68PI2oeAYE7qEvXRXibh2xr3YZTrBD qEnIa2N31OXcAkQJ65aN8vMBoBYNJHPp4o5P06Hs7sR+BeJDeeo+CAKxHcSzYxXj81BZ8 wE+B/1SLkRi9ozea7kD2uHjNARGohazv/gm4DSWQA/YP+LBCTrSgra1c3dyz7Ubax47e1 Cle/rrFWWZ5gC6rJWzozoFGd60IO6gBnJ8xwMDDeSxyHllKnYkAO54STa1K/BEX3L0xpN sGIFpkEIBKWEzahFzZDDGz/9u7lGKFUF8UK0mIvHTEsCna/gvVBR6qYG4ZOvRH+UA3Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793140759; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=beIsynJTUoVVYUibNrHvS9xq2J3rMWzpCblr3XGPomY=; b=XYldxw1S5//hn9pvFxb0AP2pNIgQo79loGR9xzMuMBMRyuq/FUoJk6GzwpG1GNpTJYqj VeAcAlsnZ1oachMDfK8ipgiyjGIAGL2P9ECvXWU8qbTh7e8epKbk9pVifOPwp9GOADtYM lffWKSdnW+V3DRf1X+V9uLyIQUxCWgjSMixC6NkKIDyoxm+LRR3EEJvL94rhMbFvRy7Gv 8zlUNaC0BThwnOpE6rWSgyy2iyN/Tr1jB5saCs7CoLVMAU/msj0kL7OzEpFtUhPpop4Yh 6xhkOlVU/s0PwnTy7FX2mKfRmbR6Qg7KsaxR+YwcduFx+FaXXO65ITWd/Wusj6NwWaA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=kIMyUKFu; arc=none smtp.remote-ip=209.85.210.200 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4681C60A2608 for ; Tue, 27 Oct 2026 22:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4681C60A2608 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=kIMyUKFu Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8a05c820ecbso551606b3a.0 for ; Tue, 27 Oct 2026 15:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140759; x=1793745559; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=beIsynJTUoVVYUibNrHvS9xq2J3rMWzpCblr3XGPomY=; b=kIMyUKFukUJtjlCB+ZE2zh2lwo3GQV3z3dUYxV09PKjXw0ZjE2jeWA5BuL5r+QkTsS 5ZzU/9piUKJLhgATzOW69XBDirJSfUNdjU8bimvi6t/U9+77eeZV3sUpzjATUlpkTsmz gq3vyWIGNK0zFjlANK5GQZMvv0vsQLSwO9CijSJxrX9Vh1ynVxUpyQR+qXuUOzTQNEd2 vqFNVi+/m+qyeN1OsBM/7m5G51CLC9ESLC5hoKgrvebdkKnbj7QYKY4thO4WPGJ0SxlV i2/3GcwAryD5MX3hH5HdRpHDIt1i8yx0VLeoNGibsE95Q6GYl69dtaAIBjedJgq+ugfg pXGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140759; x=1793745559; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=beIsynJTUoVVYUibNrHvS9xq2J3rMWzpCblr3XGPomY=; b=f6BfeFvn/xhq7UdyofJNBf1hycx5twZyx0kZF2HEbU/E6JVIYCE5B5gGfAg/i24tlO 7kT+2CK51NYh9CFf2pZxDC3IE9UoFyua8IsCwKg8iH+sGNGXv1a5ZsLZJA944ONhkKT3 jOf5y6NUQfzpzexU3zzjqF5OP2i+83rXqd6k2xKGoSUTtspy22uHjmpPp1ueSwwdMhI5 pWKbLZod1kjUAkX1QIn6gSzOwJiPt4nnIzZueSK1j1wpRFnqTeDhy6jhSJ/eAQhzA5C/ gwlf/r87NnccGjpbQN0+JDOOEXzLUetFb/j9TQr6D+oD31e1O1rkbFiOpSKdAeWvqOq9 vfBw== X-Forwarded-Encrypted: i=1; AKwUvBzBlgAw8wferhWlTWxYvKnXXTvDYm0P71wQ1tRquLUIGbbyXrR9ReOmsL2rljJ2G+xdhBkgjgWEFscUfDC+@vger.kernel.org X-Gm-Message-State: AFq9FYLnMWZWlLUxavJRJdPSPSshq9FgfkPunAWFDrWpOJwcrQxP6/Zo fFw9twt5Wa4XNyGzz3oFRJaYMGTaufop3kl8xOu5CTYYETCtfQzg5g8fALJ9n7snRgp13wXkIJF kwsH/q7GpyA== X-Received: from pfbdw21.prod.google.com ([2002:a05:6a00:3695:b0:89f:827e:eb47]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4293:b0:876:194e:b8fe with SMTP id d2e1a72fcca58-8a6e70e832amr492696b3a.26.1793140758450; Tue, 27 Oct 2026 15:39:18 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:38 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-4-irogers@google.com> Subject: [PATCH v2 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Paul Mundt Content-Type: text/plain; charset="UTF-8" In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.0.313.g2479322e68-goog