From: Christoph Hellwig <hch@lst.de>
To: "Pankaj Raghav (Samsung)" <pankaj.raghav@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Wilfred Mallawa <wilfred.opensource@gmail.com>
Subject: Re: [PATCH 03/25] xfs: always call xfs_update_stable_writes in xfs_ioctl_setattr_xflags
Date: Wed, 11 Nov 2026 18:37:52 +0100 [thread overview]
Message-ID: <20261111173752.GA20167@lst.de> (raw)
In-Reply-To: <avRM1f0Lhw-Y1uxf@quentin>
On Wed, Nov 11, 2026 at 12:11:51PM +0100, Pankaj Raghav (Samsung) wrote:
> On Wed, Nov 04, 2026 at 09:57:07AM +0100, Christoph Hellwig wrote:
> > Currently xfs_update_stable_writes() is never called when the RT flag is
> > flipped because xfs_ioctl_setattr_xflags() updates ip->i_diflags before
> > comparing the rtflag variable to XFS_IS_REALTIME_INODE(ip), and thus
> > the stable flag can be set incorretly when flipping the realtime bit
> > on an existing file.
> >
> > Fix this by unconditionally calling xfs_update_stable_writes for regular
> > files.
> >
> > Fixes: d528a6c1d4b6 ("xfs: data checksums require stable writes")
>
> Shouldn't this patch be folded in to the stable writes patches?
Not really, this is a fix for patches already in mainline. Carlos
has queued this one up already, so it will be gone from the next
round.
next prev parent reply other threads:[~2026-11-11 17:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 8:57 support for RT data checksums v2 Christoph Hellwig
2026-11-04 8:57 ` [PATCH 01/25] block: export fs_bio_integrity_verify Christoph Hellwig
2026-11-04 8:57 ` [PATCH 02/25] iomap: add support for data checksumming Christoph Hellwig
2026-11-11 11:21 ` Pankaj Raghav (Samsung)
2026-11-11 17:38 ` Christoph Hellwig
2026-11-04 8:57 ` [PATCH 03/25] xfs: always call xfs_update_stable_writes in xfs_ioctl_setattr_xflags Christoph Hellwig
2026-11-11 11:11 ` Pankaj Raghav (Samsung)
2026-11-11 17:37 ` Christoph Hellwig [this message]
2026-11-04 8:57 ` [PATCH 04/25] xfs: use a separate lockdep class for all rmap inode locks Christoph Hellwig
2026-11-04 8:57 ` [PATCH 05/25] xfs: add a xfs_buf_read_async buffer cache API Christoph Hellwig
2026-11-04 8:57 ` [PATCH 06/25] xfs: add xfs_daddr_to_rgno and xfs_daddr_to_rgbno helpers Christoph Hellwig
2026-11-04 8:57 ` [PATCH 07/25] xfs: prepare xfs_rtfile_initialize_blocks for larger than FSB blocks Christoph Hellwig
2026-11-04 8:57 ` [PATCH 08/25] xfs: relase zi_open_zones_lock over xfs_open_zone_put on unmount Christoph Hellwig
2026-11-04 8:57 ` [PATCH 09/25] xfs: put the open zone outside RCU protection in xfs_get_cached_zone Christoph Hellwig
2026-11-04 8:57 ` [PATCH 10/25] xfs: define the RT data checksum on-disk format Christoph Hellwig
2026-11-04 8:57 ` [PATCH 11/25] xfs: add support for per-RTG csum files Christoph Hellwig
2026-11-04 8:57 ` [PATCH 12/25] xfs: calculate the log reservation for logging data checksum buffers Christoph Hellwig
2026-11-04 8:57 ` [PATCH 13/25] xfs: core RT data checksum support Christoph Hellwig
2026-11-04 8:57 ` [PATCH 14/25] xfs: data checksums require stable writes Christoph Hellwig
2026-11-04 8:57 ` [PATCH 15/25] xfs: require file system block size alignment when using data checksums Christoph Hellwig
2026-11-04 8:57 ` [PATCH 16/25] xfs: add support for reading with " Christoph Hellwig
2026-11-11 11:31 ` Pankaj Raghav (Samsung)
2026-11-11 17:38 ` Christoph Hellwig
2026-11-04 8:57 ` [PATCH 17/25] xfs: add support for writing " Christoph Hellwig
2026-11-04 8:57 ` [PATCH 18/25] xfs: add data checksum support to zoned garbage collection Christoph Hellwig
2026-11-04 8:57 ` [PATCH 19/25] xfs: simplify range tracking in xfs_verify_media Christoph Hellwig
2026-11-04 8:57 ` [PATCH 20/25] xfs: verify data checksums during media verification Christoph Hellwig
2026-11-11 11:57 ` Pankaj Raghav (Samsung)
2026-11-11 17:39 ` Christoph Hellwig
2026-11-04 8:57 ` [PATCH 21/25] xfs: don't try to verify checksums on empty zones Christoph Hellwig
2026-11-04 8:57 ` [PATCH 22/25] xfs: report RT data checksum information via XFS_FSOP_GEOM Christoph Hellwig
2026-11-04 8:57 ` [PATCH 23/25] xfs: add an experimental feature warning for RT data checksums Christoph Hellwig
2026-11-04 8:57 ` [PATCH 24/25] xfs: enable " Christoph Hellwig
2026-11-04 8:57 ` [PATCH 25/25] xfs: add a RT checksum log item Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111173752.GA20167@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pankaj.raghav@linux.dev \
--cc=wilfred.opensource@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox