From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.160 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795039337; b=mwK6F2CDbPXPb7TRb/+QX7CDOdLcEB389G4m0PtgIFbFNWTODjtP93283rCXpZJTYpNp X7rL5BHABcpSHg10Ok0Kw2D7l91bN/ek/uYLxsI0mxZZg8kO276+Teb9lfZ6JvlGw958U z6ZslepGumv+o09PKCCL9lFj71t6e7LNv+MMooPGWyz6o6iZo4ydiioHJ+UC06gUyd5EQ wBwoPy4rJPEpnrvWtLgi6JENkzrDwOZaLIAVjjnrNbGiVzlnLhMhz/tMMPN+dZd22z6WV 2D26ZilrFxO5vukxHhaAM1DXEvI1GVtKHDE5aauj3TN9E6mpL9Lfumcjphe2eKyu+/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795039337; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=yo1xabyV53whMmg+uxEow2PfMUc1Q6vU1aHwVTSuikI=; b=wEYDaZ17R9BGBIt72jYX4veuTMgKtC2ysBcqqkWby0g2ZWGQiJ8tJeK59Kk1VIVK8C6v 2k0B4Kgh51n/aGpkNtddW983vaV1NQB9hSNRljv2elMaeozhmQFR/miSPOhaX3v7DrhhY lYu1BjAE8lvFlfrspJAYyE6lN4bNOHSNUSkR18CyKjjv9rFmxhgk38RRstJNd11fSMcCN usrwQ0PQrkW/aY6/gZsFU674K/XHiKUHpEAguRDLalbIa7+44Ny1hCcBn56j1kc12y2Sr eA79naF0L4HsUGbpddi/hWZyV2lDOdrEKLBkQZBvG1MOjNipx7Sfc39d9IM/vE9Cofw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=DKZQsHKv; arc=none smtp.remote-ip=95.215.58.160 Received: from mta1.migadu.com (out-160.mta1.migadu.com [95.215.58.160]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18C460A2601 for ; Wed, 18 Nov 2026 22:02:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C18C460A2601 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=DKZQsHKv X-Envelope-To: linux-fsdevel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=9J/3TDko6vY0D7TedDlj7aNBGBfEkr+tAX65XefiW4Q=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795039334; v=1; x=1795644134; b=DKZQsHKvJrNcmzNjbFo+q0AGD17JeC4sM4S4eHzyo9d1inA50W/Yb8VDs9JIFUGkfZJ8nAFp I4K3/RYb8jug7b8Rfvphv/pFnXmUSa1qFv+CBpJTMmPMhJ+a01w0LZCltH3BjJMx2EWWQqrDczy QR37j/1/ZiUU5ZHMsLVmM3So= X-Envelope-To: linux-fsdevel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id b9bcccd00ec84c2f; Wed, 18 Nov 2026 22:02:14 +0000 X-Mizu-Trace-ID: b9bcccd00ec84c2f X-Migadu-Flow: FLOW_OUT From: Shakeel Butt To: Christian Brauner Cc: Greg Kroah-Hartman , Tejun Heo , Jori Koolstra , Ian Kent , "T . J . Mercier" , Meta kernel team , linux-fsdevel@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] kernfs: don't take kernfs_iattr_rwsem in __kernfs_remove() Date: Wed, 18 Nov 2026 14:01:53 -0800 Message-ID: <20261118220154.2965621-7-shakeel.butt@linux.dev> X-Mailer: git-send-email 2.53.1 In-Reply-To: <20261118220154.2965621-1-shakeel.butt@linux.dev> References: <20261118220154.2965621-1-shakeel.butt@linux.dev> X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __kernfs_remove() takes kernfs_iattr_rwsem for writing around kernfs_clear_inode_nlink() for every removed node. A cgroup rmdir removes the directory and all its files, so it takes the lock once per file, each time behind the readers. Our lock monitor saw rmdirs wait in __kernfs_remove() for several seconds. Commit eea5d2bb34ba ("kernfs: Send IN_DELETE_SELF and IN_IGNORED") clears i_nlink inside this section, so a refresh in progress could not set a removed directory's i_nlink again, the race described in commit 507d8ce13f5b ("kernfs: Don't set_nlink for directories being removed"). The refresh no longer sets i_nlink. Only inode setup does, under kernfs_rwsem, which __kernfs_remove() holds for writing. A racing fstat() of a file can read its i_nlink while it is cleared, and sees 1 or 0, as on other filesystems. A directory reports its link count from the node. Drop the lock. rmdir no longer takes kernfs_iattr_rwsem for writing. kernfs_iattr_rwsem write acquisitions (lock_stat), before -> after: 5 dummy netdevs created and removed 370 -> 0 100 cgroup mkdirs and 100 rmdirs 1500 -> 0 Signed-off-by: Shakeel Butt --- fs/kernfs/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c index 8686219b826f..c1402a461405 100644 --- a/fs/kernfs/dir.c +++ b/fs/kernfs/dir.c @@ -1625,9 +1625,7 @@ static void __kernfs_remove(struct kernfs_node *kn) * to decide who's responsible for cleanups. */ if (!parent || kernfs_unlink_sibling(pos)) { - down_write(&kernfs_root(kn)->kernfs_iattr_rwsem); kernfs_clear_inode_nlink(pos); - up_write(&kernfs_root(kn)->kernfs_iattr_rwsem); if (parent) kernfs_dir_update_times(parent); -- 2.53.1-Meta