From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. R. Okajima" Subject: Re: [RFC PATCH] Show data flow for file copyup in unions Date: Wed, 17 Mar 2010 07:51:31 +0900 Message-ID: <20335.1268779891@jrobl> References: <20100316181711.GB24819@shell> Cc: Alexander Viro , Miklos Szeredi , Dmitry Monakhov , Jeff Layton , Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Valerie Aurora Return-path: In-Reply-To: <20100316181711.GB24819@shell> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Valerie Aurora: > 1. Don't copyup if the operation would fail (e.g., open(O_WRONLY) on a > file with mode 444). It's inefficient and a possible security hole to > copy up a file if no write (or maybe even read) can occur anyway. Just a question. How about this case? When the file is writable (0644 or something) but its parent directory is readonly (0555), do you think the file should be copied-up? J. R. Okajima