From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, chandan@mykolab.com
Subject: Re: [PATCH] generic/224: Increase filesystem instance size to 1.5 GiB
Date: Tue, 22 Sep 2015 10:48:32 +0530 [thread overview]
Message-ID: <2034993.iSlvTmyeNT@localhost.localdomain> (raw)
In-Reply-To: <55F230A3.2070300@cn.fujitsu.com>
On Friday 11 Sep 2015 09:38:43 Qu Wenruo wrote:
Qu, Sorry for the late response. My email client's filtering had broken and
hence I did not see your response until now.
> Hi Chandan,
>
> Although the reply may be a little late, but I think it's still better
> to fix the bug in mkfs.btrfs.
>
> The core problem is, why mkfs.btrfs is insisting on make the fs into
> mixed-bg.
>
> Auto detection for small device and make it into mixed-bg should be a
> "OPTIONAL" feature, not a "mandatory" one.
>
> So IMHO, the best method is to disable mixed-bg when nodesize/sectorsize
> is given and differs and user doesn't force mkfs to create mixed-bg.
>
My understanding of the chunk allocator (i.e. __btrfs_alloc_chunk()) was
incomplete. Looking into the code more thoroughly I now realize that 'small
filesystem detection and mixed-bg creation' can be made optional. Thanks for
the suggestion.
--
chandan
prev parent reply other threads:[~2015-09-22 5:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 14:46 [PATCH] generic/224: Increase filesystem instance size to 1.5 GiB Chandan Rajendra
2015-08-31 18:11 ` Theodore Ts'o
2015-08-31 19:19 ` Austin S Hemmelgarn
2015-08-31 21:09 ` Theodore Ts'o
2015-09-01 0:19 ` Chandan Rajendra
2015-09-01 0:38 ` Chandan Rajendra
2015-09-01 2:15 ` Theodore Ts'o
2015-09-01 2:33 ` Chandan Rajendra
2015-09-11 1:38 ` Qu Wenruo
2015-09-22 5:18 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2034993.iSlvTmyeNT@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=chandan@mykolab.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).