From: Hyeongseok Kim <hyeongseok@gmail.com>
To: Sungjong Seo <sj1557.seo@samsung.com>, namjae.jeon@samsung.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exfat: fix erroneous discard when clear cluster bit
Date: Tue, 2 Mar 2021 15:28:49 +0900 [thread overview]
Message-ID: <206deada-bb28-e19a-d79a-1075501bbfe3@gmail.com> (raw)
In-Reply-To: <000001d70f0d$8e882ec0$ab988c40$@samsung.com>
On 3/2/21 11:41 AM, Sungjong Seo wrote:
>> Subject: [PATCH] exfat: fix erroneous discard when clear cluster bit
>>
>> If mounted with discard option, exFAT issues discard command when clear
>> cluster bit to remove file. But the input parameter of cluster-to-sector
>> calculation is abnormally adds reserved cluster size which is 2, leading
>> to discard unrelated sectors included in target+2 cluster.
>>
>> Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
>> Signed-off-by: Hyeongseok Kim <hyeongseok@gmail.com>
>> ---
>> fs/exfat/balloc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
> Looks good.
>
> Acked-by: Sungjong Seo <sj1557.seo@samsung.com>
>
> Thanks for your work!
> Could you remove the wrong comments above set/clear/find bitmap functions
> together?
>
Done, in V2.
Thanks for the review.
prev parent reply other threads:[~2021-03-02 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210225093351epcas1p40377b00fb3532e734e4a7a1233ee72e1@epcas1p4.samsung.com>
2021-02-25 9:33 ` [PATCH] exfat: fix erroneous discard when clear cluster bit Hyeongseok Kim
2021-03-02 2:41 ` Sungjong Seo
2021-03-02 6:28 ` Hyeongseok Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=206deada-bb28-e19a-d79a-1075501bbfe3@gmail.com \
--to=hyeongseok@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).