Linux filesystem development
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: hengyul@cs.unc.edu
Cc: jack@suse.cz,brauner@kernel.org,matthias.goergens@gmail.com,linux-fsdevel@vger.kernel.org,linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isofs: Fix handling of directories with small logical blocks
Date: Mon, 12 Oct 2026 12:07:22 +0200	[thread overview]
Message-ID: <21101510237286364126@scdbackup.webframe.org> (raw)
In-Reply-To: <20261012021004.2105580-1-hengyul@cs.unc.edu>

Hi,

Hengyu Liang wrote:
> As far as I can see, the option sets the size of the buffer that is
> read, but not the place. The loop over the volume descriptors has
> 
>         block = iso_blknum << (ISOFS_BLOCK_BITS - s->s_blocksize_bits);

I see. The code of fs/isofs surprises me every time i look at it.


> I think 2048 is the right value for the check.

I now agree.

(Actually i think 2048 is the only right value for Sector and Block.
Everything else is just weird.
libisofs did not check Logical Block Size at all. Yesterday i committed
"Prevented reading of filesystems with logical block size != 2048".)


Have a nice day :)

Thomas


      reply	other threads:[~2026-10-12 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 17:56 [PATCH] isofs: Fix handling of directories with small logical blocks Hengyu Liang
2026-10-11 20:29 ` Thomas Schmitt
2026-10-12  2:10   ` Hengyu Liang
2026-10-12 10:07     ` Thomas Schmitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21101510237286364126@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=brauner@kernel.org \
    --cc=hengyul@cs.unc.edu \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.goergens@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox