From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode() Date: Tue, 02 Oct 2007 13:58:24 +0100 Message-ID: <21295.1191329904@redhat.com> References: <20071002100610.GA25647@atrey.karlin.mff.cuni.cz> <20071001130921.29339.72876.stgit@warthog.procyon.org.uk> <20071001131018.29339.40931.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, hch@infradead.org, viro@ftp.linux.org.uk, torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from mx1.redhat.com ([66.187.233.31]:47785 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbXJBM67 (ORCPT ); Tue, 2 Oct 2007 08:58:59 -0400 In-Reply-To: <20071002100610.GA25647@atrey.karlin.mff.cuni.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Jan Kara wrote: > Hmm, why don't you use the return value from raw_inode? It can be > either -EIO or -EINVAL if 'ino' was invalid... Good point. Altered. David